-
Notifications
You must be signed in to change notification settings - Fork 862
Add more parameters to daily papers #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good PR @Samoed ! Thanks for completing this API. I've left a few comments regarding default values and tests but apart from that I feel we are close to getting this merged.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Don't worry about the failing tests, they are not related to your PR 🤗 |
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! Everything looks good to me. Will merge it once CI is green 🤗
|
Run linter |
|
thanks for the linting, time to merge now :) |
Ref #3502 (review)
Adding parameters to
list_daily_papers: