Add retry for preupload endpoint #3588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/preupload/endpoint is called in chunks of 256 files when uploading to the Hub. for large uploads, this means multiple sequential API calls, making it more likely to hit rate limits. Also, thanks to @Wauplin's dashboard (private link), we can see quite a lot of 429 errors on this endpoint in the last 24h.let's take advantage of the rate limit header parsing to introduce smart retry handling. the PR also introduces backoff retry for transient errors (5xx).