Compact output in snapshot_download and hf download
#3523
Merged
+89
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
Nov 4, 2025
Contributor
hanouticelina
left a comment
hanouticelina
left a comment
There was a problem hiding this comment.
tested it locally, it looks great! thank you
| # This progress bar is shared across threads/files and gets updated each time we fetch | ||
| # metadata for a file. | ||
| bytes_progress = tqdm_class( | ||
| desc="Downloading (incomplete total...)", |
Contributor
There was a problem hiding this comment.
(nit) maybe a clearer wording?
Suggested change
| desc="Downloading (incomplete total...)", | |
| desc="Downloading (total size unknown...)", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
snapshot_downloadandhf downloadoutput is very verbose. We have 2-3 messages per file + 1 progress bar per file. On most repos, it makes the output unreadable. This PR fixes that by switching the "downloading file to ...", "moving file to ...", "file in cache", etc. messages toDEBUGlevel instead ofINFO, and by combining all per-file progress bars into a single one. In practice this "bytes downloading" progress bar is only an estimate because we can't know in advance how much bytes will be downloaded. It is still a much better indicator than before (in my opinion^^).As a side effect, this PR adds a
tqdm_classparameter tohf_hub_downloadto control progress bar for individual files (as already the case insnapshot_download).Here is a recording of how it looks like in the terminal:
Screencast.from.04-11-2025.15.10.07.webm
It should also greatly improve the output in non-TTY env, typically Spaces (cc @cbensimon)