Skip to content

max_seq_length should not be larger than any options #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

max_seq_length should not be larger than any options #3255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eeb3ba
max_seq_length should not be larger than any options
amitport Mar 1, 2025
be51100
Merge branch 'master' of https://github.com/UKPLab/sentence-transform…
tomaarsen Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions sentence_transformers/models/Transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,18 @@ def __init__(
**tokenizer_args,
)

# No max_seq_length set. Try to infer from model
max_seq_options = []
if max_seq_length is None:
if (
hasattr(self.auto_model, "config")
and hasattr(self.auto_model.config, "max_position_embeddings")
and hasattr(self.tokenizer, "model_max_length")
):
max_seq_length = min(self.auto_model.config.max_position_embeddings, self.tokenizer.model_max_length)

self.max_seq_length = max_seq_length
max_seq_options.append(max_seq_length)
if (
hasattr(self.auto_model, "config")
and hasattr(self.auto_model.config, "max_position_embeddings")
):
max_seq_options.append(self.auto_model.config.max_position_embeddings)
if hasattr(self.tokenizer, "model_max_length"):
max_seq_options.append(self.tokenizer.model_max_length)

self.max_seq_length = min(max_seq_options)

if tokenizer_name_or_path is not None:
self.auto_model.config.tokenizer_class = self.tokenizer.__class__.__name__
Expand Down
Loading