Skip to content

Conversation

@lucteo
Copy link
Contributor

@lucteo lucteo commented Oct 7, 2025

Remove Block.AbsoluteID

Replace its use in Emitter with a simpler structure.

Replace its use in Emitter with a simpler structure.
@lucteo lucteo requested a review from kyouko-taiga October 7, 2025 19:58
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (be3804a) to head (c72377e).
⚠️ Report is 46 commits behind head on backend-refactor.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           backend-refactor    #1738      +/-   ##
====================================================
- Coverage             88.23%   88.14%   -0.10%     
====================================================
  Files                   382      385       +3     
  Lines                 24168    24218      +50     
====================================================
+ Hits                  21325    21347      +22     
- Misses                 2843     2871      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucteo lucteo merged commit a10bd46 into backend-refactor Oct 30, 2025
23 of 24 checks passed
@lucteo lucteo deleted the remove-block-absolute-id branch October 30, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants