-
Notifications
You must be signed in to change notification settings - Fork 60
Remove Block.AbsoluteID
#1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Block.AbsoluteID
#1738
Conversation
Replace its use in Emitter with a simpler structure.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## backend-refactor #1738 +/- ##
====================================================
- Coverage 88.23% 88.14% -0.10%
====================================================
Files 382 385 +3
Lines 24168 24218 +50
====================================================
+ Hits 21325 21347 +22
- Misses 2843 2871 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments.
Co-authored-by: Dimi Racordon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove
Block.AbsoluteIDReplace its use in Emitter with a simpler structure.