Skip to content

Commit 8f9edbe

Browse files
committed
fix traceOpcodes defaults and changelog
Signed-off-by: Luis Pinto <[email protected]>
1 parent 41a024e commit 8f9edbe

File tree

6 files changed

+9
-2
lines changed

6 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- Add blockTimestamp to receipt logs for `eth_getBlockReceipts` and `eth_getTransactionReceipt` results [#9294](https://github.com/hyperledger/besu/pull/9294)
1919
- Upgrade to execution-spec-tests v5.3.0 [#9301](https://github.com/hyperledger/besu/pull/9301)
2020
- Ability to enable/disable stack, storage and returnData tracing data in debug_traceStandardBlockToFile and debug_traceStandardBadBlockToFile endpoints [#9183](https://github.com/hyperledger/besu/pull/9183)
21+
- Add `opcodes` optional parameter to RPC methods: `debug_standardTraceBlockToFile`, `debug_standardTraceBadBlockToFile`, `debug_traceBlockByNumber`, `debug_traceBlockByHash`, `debug_traceTransaction`, `debug_traceBlock`, `debug_traceCall` for tracing specified opcodes [#9335](https://github.com/hyperledger/besu/pull/9335)
2122

2223
### Bug fixes
2324

ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/EvmToolCommand.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
import java.io.PrintWriter;
5555
import java.util.ArrayList;
5656
import java.util.Arrays;
57+
import java.util.Collections;
5758
import java.util.Comparator;
5859
import java.util.Deque;
5960
import java.util.LinkedHashMap;
@@ -471,6 +472,7 @@ public void run() {
471472
.traceStack(!hideStack)
472473
.traceReturnData(showReturnData)
473474
.traceStorage(showStorage)
475+
.traceOpcodes(Collections.emptySet())
474476
.eip3155Strict(eip3155strict)
475477
.build())
476478
: OperationTracer.NO_TRACING;

ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/StateTestSubCommand.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
import java.io.InputStreamReader;
5050
import java.nio.file.Path;
5151
import java.util.ArrayList;
52+
import java.util.Collections;
5253
import java.util.List;
5354
import java.util.Map;
5455
import java.util.concurrent.TimeUnit;
@@ -220,6 +221,7 @@ private void traceTestSpecs(
220221
.traceStack(!parentCommand.hideStack)
221222
.traceReturnData(parentCommand.showReturnData)
222223
.traceStorage(parentCommand.showStorage)
224+
.traceOpcodes(Collections.emptySet())
223225
.eip3155Strict(parentCommand.eip3155strict)
224226
.build())
225227
: OperationTracer.NO_TRACING;

ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/T8nServerSubCommand.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import java.nio.charset.StandardCharsets;
3838
import java.nio.file.Path;
3939
import java.util.ArrayList;
40+
import java.util.Collections;
4041
import java.util.HashMap;
4142
import java.util.List;
4243
import java.util.Map;
@@ -212,6 +213,7 @@ public OperationTracer getManagedTracer(final int txIndex, final Hash txHash)
212213
.traceStack(!parentCommand.hideStack)
213214
.traceReturnData(parentCommand.showReturnData)
214215
.traceStorage(parentCommand.showStorage)
216+
.traceOpcodes(Collections.emptySet())
215217
.eip3155Strict(parentCommand.eip3155strict)
216218
.build());
217219
outputStreams.put(jsonTracer, traceDest);

ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/T8nSubCommand.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ public OperationTracer getManagedTracer(final int txIndex, final Hash txHash)
282282
.traceStack(!parentCommand.hideStack)
283283
.traceReturnData(parentCommand.showReturnData)
284284
.traceStorage(parentCommand.showStorage)
285+
.traceOpcodes(Collections.emptySet())
285286
.eip3155Strict(parentCommand.eip3155strict)
286287
.build());
287288
outputStreams.put(jsonTracer, traceDest);

evm/src/test/java/org/hyperledger/besu/evm/tracing/StreamingOperationTracerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,8 @@ void eip3155ModifiedTestCaseStrictTypes() {
4040
StreamingOperationTracer tracer =
4141
new StreamingOperationTracer(
4242
out,
43-
OpCodeTracerConfigBuilder.create()
43+
OpCodeTracerConfigBuilder.createFrom(OpCodeTracerConfig.DEFAULT)
4444
.traceMemory(true)
45-
.traceStack(true)
4645
.traceReturnData(true)
4746
.traceStorage(false)
4847
.eip3155Strict(true)

0 commit comments

Comments
 (0)