Add parameterised tests for UInt256 #9264
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Following Ameziane's review and benchmarking, we decided to reinclude two elements. Firstly, ModOperation itself should check if the modulus is zero, shortcutting the UInt256 constructor for the numerator. Secondly, benchmarks should reincorporate the fully random test: number of bytes are chosen uniformly at random, and then bytes are filled uniformly at random. Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Benchmarks for different sizes and fully random inputs were added for addmod, similarly to mod's benchmarks. Signed-off-by: Thomas Zamojski <[email protected]>
MulMod operation is accelerated using custom UInt256 custom implementation. Signed-off-by: Thomas Zamojski <[email protected]>
Adds mulmod benchmarks, fixes spotless and fixes random seed in UInt256Test. Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Fix bugs found by tests Signed-off-by: Simon Dudley <[email protected]>
siladu
force-pushed
the
uint256-op-modulus-parameterised-tests
branch
from
f456ffc to
62c7946
Compare
Signed-off-by: Simon Dudley <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix issues found by tests
Heavily inspired by https://github.com/NethermindEth/int256
PR is built on top of #9188