bugs: v2 generator list of bugs on comparisions

[Anmol1696]

Overview

A couple of issues with the generator:

• configmaps structure: extra new lines in configmaps for scripts loaded
• registry cofigmap is incorrect, need configmaps per chain instead of a single configmap with half required lists
• targetPort in service seems to be a string in kubernetesjs, but a number in helm export. Need to verify
• mertrics port present in service even if monitoring is disabled
• selector is incorrect in registry service: selector: {app: registry} instead of k8s label
• ports inside container spec for deployment, explorer, not needed
• mountpath incorrect for explorer: should be /home/explorer/chains/mainnet got /explorer
• command missing from explorer Deployment
• readinessProbe and livenessProbe missing in explorer deployment
• selector incorrect in registry deployment
• template.metadata.labels is incoorect in registry deployment
• no initContainer for waiting for chains before registry deployment
• imagePullPolicy missing in registry deployment container
• env missing some fields in registry deployment: NAMESPACE, REGISTRY_CHAIN_CLIENT_IDS, REGISTRY_CHAIN_CLIENT_NAMES
• env.REGISTRY_CHAIN_CLIENT_RPCS inncorect in registry deployment
• incorrect readinessProbe, should be tcpSocket for both in registry deployment
• inncorect volumes for configmaps in registry deployments
• TIMEOUT_* env missing in genesis statefulsets for cosmos
• faucet volumeMount extra in validator statefulset
• wrong image in relayer init-exposer
• wait-for-chains is wrong for hermes relayers
• RELAYER_INDEX wrongly set in env for hermes relayer statefulsets
• osmosis-1-cli not added properly in init-relayer
• resources not propogated in init-relayers same as the main resources
• resources for validator node not same as genesis node.

[Anmol1696]

Some more issues found on comparison testing:

• Relayer does not use node resources, sets 0.2 instead of 0.5
• Faucet being added to the validator, when it should just be in the genesis node
• Somehow some resource is using memory: 128M and CPU 0.2, that should not be the case
• explorer readiness and liveness probe missing
• explorer extra ports defined in Deployment
• explorer command missing
• explorer config sets only single rpc, should be 2
• explorer config coin_type set to number instead of string
• validator has faucet port, makes no sense
• registry command missing
• monitoring config should replace $NAMESPACE with something useful before running the pods
• scripts not injected properly, key name is not used. If set in default, name of file in configmap not correct. Check xpla, injective, neutron etc.
• go-relayer securityContext not set in go-relayer
• go-relayer incorrect command for starting the node
• go-realyer fix the start command
• go-relayer config namespace is not replaced
• neutron-query-relayer image is inccorectly used
• neutron-query-relayer start command not the same, please check
• neutron-query-relayer env variables incorrect
• neutron-query-relayer incorrect service port, using mertircs instead of rest port
• neutron-query-relayer configmap all wrong
• hermes create connection command absent, directly have a create channel command after it. Eg: neutron.yaml
• hermes inccorect use of RLY_INDEX vs RELAYER_INDEX in key mnemonics, check
• genesis METRICS env set to false instead of empty, check its implications
• ethereum code in config might not be correct
• persistenceCore example, DAEMON_NAME repeated 2 times
• hermes RELAYER_INDEX set wrong in env variables