Skip to content

Commit c7dfd00

Browse files
committed
fix: update binaries for windows and vscode
1 parent 6741b7f commit c7dfd00

File tree

5 files changed

+18
-30
lines changed

5 files changed

+18
-30
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ ibm_db: 2.8.1
4444

4545
- For Node.js >= V15.x on RHEL and RHEL 8.x, GCC v8.2.1 is required.
4646

47-
- The latest node.js version using which `ibm_db` is tested: 18.6.0
47+
- The latest node.js version using which `ibm_db` is tested: 18.8.0
4848

4949
## Install
5050

build.zip

43.4 KB
Binary file not shown.

installer/driverInstall.js

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ var platform = os.platform();
2525
var arch = os.arch();
2626

2727
var vscode_build = false;
28-
var electron_version = '18.3.5';
28+
var electron_version = '19.0.12';
2929
var downloadProgress = 0;
3030
var silentInstallation = false;
3131

@@ -611,9 +611,9 @@ var install_node_ibm_db = function(file_url) {
611611
var ODBC_BINDINGS_V11 = 'build\/Release\/odbc_bindings.node.11.15.0';
612612
var ODBC_BINDINGS_V12 = 'build\/Release\/odbc_bindings.node.12.22.12';
613613
var ODBC_BINDINGS_V13 = 'build\/Release\/odbc_bindings.node.13.14.0';
614-
var ODBC_BINDINGS_V14 = 'build\/Release\/odbc_bindings.node.14.19.3';
614+
var ODBC_BINDINGS_V14 = 'build\/Release\/odbc_bindings.node.14.20.0';
615615
var ODBC_BINDINGS_V15 = 'build\/Release\/odbc_bindings.node.15.14.0';
616-
var ODBC_BINDINGS_V16 = 'build\/Release\/odbc_bindings.node.16.15.1';
616+
var ODBC_BINDINGS_V16 = 'build\/Release\/odbc_bindings.node.16.17.0';
617617
var ODBC_BINDINGS_V17 = 'build\/Release\/odbc_bindings.node.17.9.1';
618618

619619
// Windows add-on binary for node.js v0.10.x, v0.12.7, 4.x, 6.x, 7.x and 8.x has been discontinued.
@@ -834,27 +834,15 @@ function findElectronVersion() {
834834
var codeOut = execSync('code --version').toString();
835835
vscodeVer = parseFloat(codeOut.split('\n')[0]);
836836
if(!isNaN(vscodeVer)) {
837-
if (vscodeVer >= 1.69){
837+
if (vscodeVer >= 1.71){
838+
electron_version = "19.0.12";
839+
}
840+
else if (vscodeVer >= 1.69){
838841
electron_version = "18.3.5";
839842
}
840-
else if (vscodeVer >= 1.67){
843+
else {// vscode version older than 1.67 not supported
841844
electron_version = "17.4.1";
842845
}
843-
else if (vscodeVer >= 1.66){
844-
electron_version = "17.2.0";
845-
}
846-
else if (vscodeVer >= 1.63){
847-
electron_version = "13.5.2";
848-
}
849-
else if (vscodeVer >= 1.56){
850-
electron_version = "12.0.4";
851-
}
852-
else if (vscodeVer >= 1.53){
853-
electron_version = "11.2.1";
854-
}
855-
else {// vscode version older than 1.53 not supported
856-
electron_version = "7.1.11"; // old binary, not getting updated.
857-
}
858846
printMsg("Detected VSCode version" + vscodeVer +
859847
", will use Electron version " + electron_version);
860848
}

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"fs-extra": "^8.1.0",
3333
"fstream": "^1.0.12",
3434
"lodash": "^4.17.21",
35-
"nan": "^2.15.0",
35+
"nan": "^2.16.0",
3636
"q": "^1.5.1",
3737
"targz": "^1.0.1",
3838
"unzipper": "^0.10.11"

0 commit comments

Comments
 (0)