Fix buffer presentation in iced_tiny_skia
#3032
Merged
+26
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
force-pushed
the
tiny-skia/damage-fix
branch
2 times, most recently
from
784d5c9 to
e79a7e3
Compare
hecrj
changed the title
iced_tiny_skia
hecrj
approved these changes
Nov 29, 2025
Member
hecrj
left a comment
hecrj
left a comment
There was a problem hiding this comment.
Thanks!
I'm unconvinced adding further frame damage calculation will be worth the cost.
We can fix the issue by skipping the redraw but still present the buffer.
hecrj
force-pushed
the
tiny-skia/damage-fix
branch
3 times, most recently
from
81d358a to
403c766
Compare
Co-authored-by: Ottatop <[email protected]>
hecrj
force-pushed
the
tiny-skia/damage-fix
branch
from
403c766 to
5db08b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tiny-skia renderer uses buffer damage to determine whether or not it should draw and present. This leads to artifacts like some button hovers failing to redraw the window:
damage-issue.mov
To fix the issue, the first commit in this PR additionally calculates damage since the last presented frame to make the determination.
This PR also changes the tiny-skia renderer to present with damage (2nd commit) now that we have the correct frame damage. I can split that off into a different PR if desired or drop it entirely if it's out of scope.