Skip to content

Doc comments are not formatted correctly #65

@stephen-smith

Description

@stephen-smith

When trying to use :'<,'>gq to wrap doc comments (||| leader) the comment leader is not created on new lines, and may actually be treated as a word and joined into a previous, short line.

In addition, when pressing <Enter> in insert mode when inside a doc comment, the comment lead isn't inserted.

This seems related to e8563c4 which overwrites comments and formatoptions that are set in the main ftplugin/idris.vim with clearly inferior versions. But, based on the commit message was meant to help limit the surface area of a security issue.

case Has the underlying security issue been addressed completely?
Yes good -> Would a patch removing comments and formatoptions from the after script be accepted?
No still_vulnerable -> Anyone have a sketch of what needs to change to address the vulnerability? Do we need more shellescape calls somewhere? <|> Left (still_vulnerable ?exploit)

@raichoo

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions