Github Release action discards existing release notes

[ilius]

This Github action ncipollo/release-action@v1 simply removes the release notes of the existing release

• With generateReleaseNotes: true, replaces it with auto-generated notes which for us does not cover most of the changes.
• With generateReleaseNotes: false, completely removes the notes.

FYI @glowinthedark
I save the release notes in doc/releases/ folder, but I have to remember to copy-paste it into the last release every time!

Creation of release is the only part I don't want to automate. Because I want to use Github's auto-generated notes but paste my own notes, and then look at the preview to see how it looks before I submit.

I have this script release-new-version-github that automates everything that can be easily automated. The most time consuming part is organizing, summarizing and simpifying git log for not-so-technical users.

[glowinthedark]

oops, then maybe replace ncipollo/release-action@v1 with github's official cli tool gh? did this for python-lzo action that has already been merged:

• https://github.com/jd-boyd/python-lzo/blob/main/.github/workflows/build-windows.yml#L82

another example from goldendict-ng of using gh directly with notes from a custom file:

• https://github.com/xiaoyifang/goldendict-ng/blob/staged/.github/workflows/Release-all.yml#L228

it accepts a switch like --notes-file=./changelog.txt and changelog.txt itself is generated in another workflow step in Release-all.yml#L175. The template is defined in cliff.toml

these are required gh to work:

    permissions:
      contents: write

    env:
      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[ilius]

@glowinthedark Adding omitBodyDuringUpdate: true option seems to fix the issue!

Indicates if the release body should be omitted during updates. The body will still be applied for newly created releases. This will preserve the existing body during updates.

I feel like this should be the default LOL.