Bugfix: get search attributes with more tests (#19)

Author: longquanzheng

integ/persistence_test.go

@@ -2,6 +2,9 @@ package integ
 
 import (
 	"context"
+	"fmt"
+	"github.com/iworkflowio/iwf-golang-sdk/gen/iwfidl"
+	"github.com/iworkflowio/iwf-golang-sdk/iwf"
 	"github.com/stretchr/testify/assert"
 	"strconv"
 	"testing"
@@ -20,4 +23,42 @@ func TestPersistenceWorkflow(t *testing.T) {
 	assert.NotEmpty(t, runId)
 	err = client.GetSimpleWorkflowResult(context.Background(), wfId, "", nil)
 	assert.Nil(t, err)
+	info, err := client.DescribeWorkflow(context.Background(), wfId, "")
+	assert.Nil(t, err)
+	assert.Equal(t, iwfidl.COMPLETED, info.Status)
+	dos, err := client.GetWorkflowDataObjects(context.Background(), &persistenceWorkflow{}, wfId, "", []string{
+		testDataObjectKey,
+	})
+	assert.Nil(t, err)
+	assert.Equal(t, 1, len(dos))
+	var do ExampleDataObjectModel
+	dos[testDataObjectKey].Get(&do)
+	assert.Equal(t, wfId, do.StrValue)
+
+	sas, err := client.GetWorkflowSearchAttributes(context.Background(), &persistenceWorkflow{}, wfId, "", []string{
+		testSearchAttributeKeyword,
+		testSearchAttributeText,
+		testSearchAttributeBool,
+		testSearchAttributeDatetime,
+		testSearchAttributeInt,
+		testSearchAttributeDouble,
+	})
+	assert.Nil(t, err)
+	expectedSas := map[string]interface{}{
+		testSearchAttributeKeyword:  "iWF",
+		testSearchAttributeText:     "Hail iWF!",
+		testSearchAttributeBool:     true,
+		testSearchAttributeDatetime: sas[testSearchAttributeDatetime], // skip this one
+		testSearchAttributeInt:      int64(1),
+		testSearchAttributeDouble:   1.0,
+	}
+	assert.Equal(t, expectedSas, sas)
+
+	resp, err := client.SearchWorkflow(context.Background(), iwfidl.WorkflowSearchRequest{
+		Query:         fmt.Sprintf("IwfWorkflowType='%v'", iwf.GetDefaultWorkflowType(&persistenceWorkflow{})),
+		PageSize:      iwfidl.PtrInt32(1),
+		NextPageToken: nil,
+	})
+	assert.Nil(t, err, iwf.GetOpenApiErrorDetailedMessage(err))
+	assert.True(t, len(resp.WorkflowExecutions) > 0)
 }

integ/persistence_workflow_state2.go

@@ -37,6 +37,10 @@ func (b persistenceWorkflowState2) Start(ctx iwf.WorkflowContext, input iwf.Obje
 	if err != nil {
 		return nil, err
 	}
+	err = persistence.SetSearchAttributeDouble(testSearchAttributeDouble, 1.0)
+	if err != nil {
+		return nil, err
+	}
 	if dv.Unix() == do.Datetime.Unix() && bv == true {
 		err := persistence.SetSearchAttributeText(testSearchAttributeText, testText)
 		if err != nil {
@@ -45,6 +49,7 @@ func (b persistenceWorkflowState2) Start(ctx iwf.WorkflowContext, input iwf.Obje
 		return iwf.EmptyCommandRequest(), nil
 	}
 	panic("the value of datatime or bool search attribute is incorrect")
+
 }
 
 func (b persistenceWorkflowState2) Decide(ctx iwf.WorkflowContext, input iwf.Object, commandResults iwf.CommandResults, persistence iwf.Persistence, communication iwf.Communication) (*iwf.StateDecision, error) {

iwf/client_impl.go

@@ -62,7 +62,7 @@ func (c *clientImpl) GetWorkflowSearchAttributes(ctx context.Context, workflow W
 	var keyAndTypes []iwfidl.SearchAttributeKeyAndType
 	for _, k := range keys {
 		keyAndTypes = append(keyAndTypes, iwfidl.SearchAttributeKeyAndType{
-			Key:       &k,
+			Key:       ptr.Any(k),
 			ValueType: ptr.Any(allTypes[k]),
 		})
 	}

iwf/errors.go

@@ -2,6 +2,7 @@ package iwf
 
 import (
 	"fmt"
+	"github.com/iworkflowio/iwf-golang-sdk/gen/iwfidl"
 	"log"
 	"net/http"
 	"runtime/debug"
@@ -90,4 +91,13 @@ func captureStateExecutionError(errPanic interface{}, retError *error) {
 		}
 		*retError = err
 	}
+}
+
+// GetOpenApiErrorDetailedMessage retrieve the API error body into a string to be human-readable
+func GetOpenApiErrorDetailedMessage(err error) string {
+	oerr, ok := err.(*iwfidl.GenericOpenAPIError)
+	if !ok {
+		return "not an OpenAPI Generic Error type"
+	}
+	return string(oerr.Body())
 }

iwf/persistence_def.go

@@ -54,6 +54,8 @@ func getSearchAttributeValue(sa iwfidl.SearchAttribute) (interface{}, error) {
 			return nil, err
 		}
 		return t, nil
+	case iwfidl.INT:
+		return *sa.IntegerValue, nil
 	default:
 		return nil, fmt.Errorf("unsupported search attribute type %v", sa.GetValueType())
 	}