Skip to content

Commit bc9d9c0

Browse files
SamuZadnickfloyd
andauthored
fix: Allow setting of parallel_requests for github.com (#2715)
Co-authored-by: Nick Floyd <[email protected]>
1 parent edbd637 commit bc9d9c0

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

github/provider.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,8 +312,8 @@ func init() {
312312
"Defaults to 1000ms or 1s if not set, the max_retries must be set to greater than zero.",
313313
"parallel_requests": "Allow the provider to make parallel API calls to GitHub. " +
314314
"You may want to set it to true when you have a private Github Enterprise without strict rate limits. " +
315-
"Although, it is not possible to enable this setting on github.com " +
316-
"because we enforce the respect of github.com's best practices to avoid hitting abuse rate limits" +
315+
"While it is possible to enable this setting on github.com, " +
316+
"github.com's best practices recommend using serialization to avoid hitting abuse rate limits" +
317317
"Defaults to false if not set",
318318
"retryable_errors": "Allow the provider to retry after receiving an error status code, the max_retries should be set for this to work" +
319319
"Defaults to [500, 502, 503, 504]",
@@ -441,9 +441,6 @@ func providerConfigure(p *schema.Provider) schema.ConfigureContextFunc {
441441

442442
parallelRequests := d.Get("parallel_requests").(bool)
443443

444-
if parallelRequests && isGithubDotCom {
445-
return nil, wrapErrors([]error{fmt.Errorf("parallel_requests cannot be true when connecting to public github")})
446-
}
447444
log.Printf("[DEBUG] Setting parallel_requests to %t", parallelRequests)
448445

449446
config := Config{

0 commit comments

Comments
 (0)