Skip to content

fix: make repository argument required #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: make repository argument required #2603

wants to merge 3 commits into from

Conversation

@mikutas
Copy link
Contributor

@mikutas mikutas commented Mar 25, 2025 •
edited
Loading

Resolves #2561

Before the change?

  • terraform plan successes without repository argument, but terraform apply fails.

After the change?

  • terraform plan fails without repository argument.
    • image

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@mikutas mikutas marked this pull request as ready for review March 26, 2025 06:57
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@vedantthapa vedantthapa mentioned this pull request Oct 5, 2025
Closed
4 tasks
vedantthapa
vedantthapa reviewed Oct 5, 2025
View reviewed changes
Copy link

@vedantthapa vedantthapa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! While you're at it, would you also mind applying the typo fix?

mikutas and others added 2 commits October 6, 2025 11:42
@mikutas @vedantthapa
fix: typo
4acfa15 
Co-authored-by: Vedant Thapa <[email protected]>
@mikutas @vedantthapa
fix: typo
2fe34d6 
Co-authored-by: Vedant Thapa <[email protected]>
@mikutas mikutas requested a review from vedantthapa October 6, 2025 02:43
vedantthapa
vedantthapa approved these changes Oct 6, 2025
View reviewed changes
Copy link

@vedantthapa vedantthapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not a maintainer though :)

@vedantthapa vedantthapa mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vedantthapa vedantthapa vedantthapa approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository_ruleset repository is optional

2 participants

@mikutas @vedantthapa