fix(github_repository_autolink_reference): Remove non-existing #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limakzi
force-pushed
the
bugfix/link-for-non-existing-repo
branch
from
0106ddb to
2b53c7d
Compare
Author
|
@nickfloyd, Is there anything I can do to help you in review? |
limakzi
force-pushed
the
bugfix/link-for-non-existing-repo
branch
from
2b53c7d to
1371ac8
Compare
…existing repository fix: Fix variable name
limakzi
force-pushed
the
bugfix/link-for-non-existing-repo
branch
from
1371ac8 to
da4ae89
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the github_repository_autolink_reference resource fails to refresh when the parent repository no longer exists. The fix adds a repository existence check before attempting to retrieve the autolink reference.
- Adds pre-check to verify repository exists before fetching autolink reference
- Removes the autolink reference from Terraform state when repository is not found
- Handles NotModified status appropriately to support ETags
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return nil | ||
| } | ||
| if ghErr.Response.StatusCode == http.StatusNotFound { | ||
| log.Printf("[INFO] Removing autolink reference from state because repository %s/%s no longer exists in GitHub", |
There was a problem hiding this comment.
There are two spaces between 'repository' and '%s/%s'. Remove the extra space.
Suggested change
| log.Printf("[INFO] Removing autolink reference from state because repository %s/%s no longer exists in GitHub", | |
| log.Printf("[INFO] Removing autolink reference from state because repository %s/%s no longer exists in GitHub", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2627
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!