feat: file modification #3204
Open
feat: file modification #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
force-pushed
the
file-mod-req
branch
2 times, most recently
from
74fd0db to
d084022
Compare
carlinmack
force-pushed
the
file-mod-req
branch
3 times, most recently
from
6399b48 to
31db9d0
Compare
Contributor
Author
|
tests pass locally. it's because it needs rdm-records to be merged |
kpsherva
reviewed
Oct 27, 2025
| rd_allowed = immediate.allowed or request.allowed | ||
| existing_request = get_existing_deletion_request(record.id) | ||
|
|
||
| if rd_allowed: |
Contributor
There was a problem hiding this comment.
isn't the feature behind a flag? should we return all this information if f.e. we in CDS do not allow any record deletions?
ntarocco
reviewed
Oct 28, 2025
carlinmack
force-pushed
the
file-mod-req
branch
2 times, most recently
from
4e69f25 to
dc62dd4
Compare
* currently the permission is whether you can unlock the files * but the files are only unlocked when you create the draft * as such as an admin when you edit a published draft, if it was created by a user it will look like the files are unlocked but this is false this PR correctly sets files_locked to whether the files are locked
carlinmack
force-pushed
the
file-mod-req
branch
2 times, most recently
from
e9b21d6 to
217bf3e
Compare
yashlamba
reviewed
Nov 7, 2025
Comment on lines
+142
to
+143
| "files": record["files"]["count"], | ||
| "internalDoi": record["pids"]["doi"]["provider"] != "external", |
Member
There was a problem hiding this comment.
Question: Could you share why was this required here?
Comment on lines
+164
to
+170
| fm_allowed = file_mod.allowed | ||
|
|
||
| file_modification = { | ||
| "enabled": file_mod.enabled, | ||
| "valid_user": file_mod.valid_user, | ||
| "allowed": fm_allowed, | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| fm_allowed = file_mod.allowed | |
| file_modification = { | |
| "enabled": file_mod.enabled, | |
| "valid_user": file_mod.valid_user, | |
| "allowed": fm_allowed, | |
| } | |
| fm_allowed = file_mod.allowed | |
| file_modification = { | |
| "enabled": file_mod.enabled, | |
| "valid_user": file_mod.valid_user, | |
| "allowed": file_mod.allowed, | |
| } |
Also, the var names are a bit confusing given we have file_mod, file_modification, and then subkeys. Could it be refactored to something intuitive? (@kpsherva and I would like to understand the naming better for ex: file mod and file_modification, why are they different?)
| return null; | ||
| } | ||
|
|
||
| if (!filesLocked && record.is_published && fileModification.context?.days_until) { |
Member
There was a problem hiding this comment.
nit: could be extract this logic out to a var?
| margin-bottom: 2rem; | ||
|
|
||
| .title { | ||
| .title:not(.ui) { |
Member
There was a problem hiding this comment.
Suggested change
| .title:not(.ui) { | |
| & > .title { |
Suggested in other UI PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
See inveniosoftware/invenio-rdm-records#2178
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: