Ignore hidden projects (#272)

Author: Rexios80

packages/custom_lint/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - Fix CI
 - Fix custom_lint not warning non-Dart files when necessary.
+- Custom_lint no-longer tries to analyze projects that lack a `.dart_tool/package_config.json`
 
 ## 0.6.7 - 2024-09-08
 

packages/custom_lint/lib/src/workspace.dart

@@ -413,14 +413,8 @@ Iterable<String> _findRoots(String path) sync* {
     if (fileName != 'pubspec.yaml' && fileName != 'analysis_options.yaml') {
       return false;
     }
-    // Check if the project has a package_config.json file.
-    final isChildFromCache =
-        file.uri.pathSegments.any((e) => e == '.dart_tool' || e == '.symlinks');
-    if (isChildFromCache) {
-      return file.parent.packageConfig.existsSync();
-    }
 
-    return true;
+    return file.parent.packageConfig.existsSync();
   }).map((file) => file.parent.path);
 }
 

packages/custom_lint/test/cli_process_test.dart

@@ -142,6 +142,20 @@ version: 0.0.1
         'ios',
         parent: app,
       );
+      createTmpFolder(
+        {
+          join(
+            'flutter',
+            'ephemeral',
+            '.plugin_symlinks',
+            'plugin_name',
+            'example',
+            'pubspec.yaml',
+          ): testDepsPubSpec,
+        },
+        'linux',
+        parent: app,
+      );
 
       final process = Process.runSync(
         'dart',
@@ -268,56 +282,6 @@ Analyzing...
       );
     }
 
-    test(
-      'missing package_config.json',
-      () async {
-        final plugin = createPlugin(name: 'test_lint', main: oyPluginSource);
-
-        final app = createLintUsage(
-          name: 'test_app',
-          source: {
-            'lib/main.dart': 'void fn() {}',
-            'lib/another.dart': 'void fail() {}',
-          },
-          plugins: {'test_lint': plugin.uri},
-        );
-
-        // Create a child context root
-        final innerContextRoot = createLintUsage(
-          name: 'test_project_inner',
-          source: {
-            'lib/main.dart': 'void fn() {}',
-            'lib/another.dart': 'void fail() {}',
-          },
-          parent: app,
-        );
-
-        // create error during initialization because of missing package_config.json
-        final packageConfig = innerContextRoot.packageConfig;
-        // Potentially resolve the file system link, temp folders are links on macOs into /private/var
-        final missingPackageConfig =
-            await innerContextRoot.resolveSymbolicLinks();
-        packageConfig.deleteSync();
-
-        final process = await Process.run(
-          'dart',
-          [customLintBinPath],
-          workingDirectory: app.path,
-        );
-
-        expect(process.exitCode, isNot(0));
-        expect(
-          trimDependencyOverridesWarning(process.stderr),
-          startsWith(
-            'Failed to decode .dart_tool/package_config.json at $missingPackageConfig. '
-            'Make sure to run `pub get` first.\n'
-            'PathNotFoundException: Cannot open file, path =',
-          ),
-        );
-        expect(process.stdout, isEmpty);
-      },
-    );
-
     test(
       'dependency conflict',
       () async {

packages/custom_lint/test/src/workspace_test.dart

@@ -2403,8 +2403,9 @@ dependency_overrides:
           final analysisFile = workspace.dir('package').analysisOptions;
           analysisFile.createSync();
           analysisFile.writeAsStringSync(analysisOptionsWithCustomLintEnabled);
-          final nestedAnalysisFile =
-              workspace.dir('package', 'test').analysisOptions;
+          final testDir = workspace.dir('package', 'test');
+          testDir.packageConfig.createSync(recursive: true);
+          final nestedAnalysisFile = testDir.analysisOptions;
           nestedAnalysisFile.createSync(recursive: true);
           nestedAnalysisFile
               .writeAsStringSync(analysisOptionsWithCustomLintEnabled);