feat(remote-config, other): expose new JS SDK implementation of realtime updates WIP #8717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime updates WIP Notes: - not currently working, no events come through yet - the e2e tests *definitely* probe realtime updates on android/ios so suspect implementation - hypothesis: reliance on ReadableStream implementation in react-native is problematic similar to ai, may need polyfill - other hypothesis: relying on firebase-js-sdk events directly may be incorrect design, auth:auth_state_changed event for instance is implemented by treating the firebase-js-sdk level event as something to be wrapped like a true native platform callback, is handled by rnfb JS 'native-like auth module' internally and re-emitted as a react-native event via EventEmitter
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
added
plugin: remote_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the new realtime updates feature shipped in firebase-js-sdk 12.3.0 in react-native-firebase's "Other" platform implementation
Notes:
for instance is implemented by treating the firebase-js-sdk level event as something to be wrapped like a true native
platform callback, is handled by rnfb JS 'native-like auth module' internally and re-emitted as a react-native event via EventEmitter
Release Summary
Will be a small series of conventional commits that will trigger the correct release notes automagically
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
The e2e tests very thoroughly probe realtime updates, and have recently been re-worked such that they are reliable in CI even (vs just running locally) so are enabled everywhere. The testing support here should be 100%, which is a good thing because the initial implementation is not working and e2e clearly shows it
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter