Skip to content

Conversation

@MichaelVerdon
Copy link
Collaborator

Description

Fixes #8635

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-native-firebase Ready Ready Preview Comment Aug 20, 2025 6:19am

@mikehardy mikehardy force-pushed the dynamic-links-del-cleanup branch from 743fb8c to e22f9f2 Compare August 16, 2025 17:55
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the README should go as well, there's no reason to keep it in my opinion

Without the README, lint passes - otherwise you have to add back that exclusion which I think is an indicator it is the wrong way to go - the package is gone, it should be really gone

I rebased to main after the package was removed from publish so I think patch-package will pass and such, we'll see what CI thinks

@MichaelVerdon MichaelVerdon merged commit fe4adfc into main Aug 20, 2025
21 of 24 checks passed
@MichaelVerdon MichaelVerdon deleted the dynamic-links-del-cleanup branch August 20, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post cleanup after Dynamic Links has been removed

4 participants