feat: remove the ModelFooter in the ModelView and add the Delete Mode… #8635
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Button from the Footer into the View
Pfannkuchensack
requested review from
blessedcoolant,
hipsterusername,
maryhipp and
psychedelicious
as code owners
Collaborator
|
Fair enough. Thank you for the PR. I also reordered the buttons to go in the order of Reindentify > Convert (when valid) > Edit > Delete which feels like the ideal model action propagation. If there's more options added in the future to this area, we can consider a drop down or reintroducing a proper model footer. |
blessedcoolant
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the ModelFooter in the ModelView and add the Delete Model Button from the Footer into the View
Summary
All the Buttons from the Footer are in the ModelView now. So the Footer is not needed in the ModelView.
Related Issues / Discussions
None
QA Instructions
Click on a Model in the Model Manager to open the ModelView. Top Right are now all Buttons needed to interactive with the model.
Merge Plan
Nothing else to consider
Checklist
What's Newcopy (if doing a release after this PR)