Skip to content

Commit e60ec91

Browse files
committed
simplify features
1 parent 06ca20e commit e60ec91

File tree

6 files changed

+17
-28
lines changed

6 files changed

+17
-28
lines changed

crates/iota-crypto/src/simple.rs

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -467,18 +467,23 @@ mod keypair {
467467
}
468468
}
469469

470-
#[cfg(all(test, feature = "pem"))]
470+
#[cfg(all(
471+
test,
472+
feature = "ed25519",
473+
feature = "secp256k1",
474+
feature = "secp256r1"
475+
))]
471476
mod test {
472477
use test_strategy::proptest;
473478
#[cfg(target_arch = "wasm32")]
474479
use wasm_bindgen_test::wasm_bindgen_test as test;
475480

476481
use super::*;
477-
use crate::ed25519::{Ed25519PrivateKey, Ed25519VerifyingKey};
478-
#[cfg(feature = "secp256k1")]
479-
use crate::secp256k1::{Secp256k1PrivateKey, Secp256k1VerifyingKey};
480-
#[cfg(feature = "secp256r1")]
481-
use crate::secp256r1::{Secp256r1PrivateKey, Secp256r1VerifyingKey};
482+
use crate::{
483+
ed25519::{Ed25519PrivateKey, Ed25519VerifyingKey},
484+
secp256k1::{Secp256k1PrivateKey, Secp256k1VerifyingKey},
485+
secp256r1::{Secp256r1PrivateKey, Secp256r1VerifyingKey},
486+
};
482487

483488
#[proptest]
484489
fn ed25519_pem_der(signer: Ed25519PrivateKey) {
@@ -495,13 +500,9 @@ mod test {
495500
assert_eq!(from_pem.public_key(), public_key);
496501

497502
// der and pem bytes don't convert to secp256r1 or secp256k1
498-
#[cfg(feature = "secp256r1")]
499503
Secp256r1PrivateKey::from_der(&ed25519_der).unwrap_err();
500-
#[cfg(feature = "secp256r1")]
501504
Secp256r1PrivateKey::from_pem(&ed25519_pem).unwrap_err();
502-
#[cfg(feature = "secp256k1")]
503505
Secp256k1PrivateKey::from_der(&ed25519_der).unwrap_err();
504-
#[cfg(feature = "secp256k1")]
505506
Secp256k1PrivateKey::from_pem(&ed25519_pem).unwrap_err();
506507

507508
// SimpleKeypair parses
@@ -523,13 +524,9 @@ mod test {
523524
assert_eq!(from_pem.public_key(), public_key);
524525

525526
// der and pem bytes don't convert to secp256r1 or secp256k1
526-
#[cfg(feature = "secp256r1")]
527527
Secp256r1VerifyingKey::from_der(&der).unwrap_err();
528-
#[cfg(feature = "secp256r1")]
529528
Secp256r1VerifyingKey::from_pem(&pem).unwrap_err();
530-
#[cfg(feature = "secp256k1")]
531529
Secp256k1VerifyingKey::from_der(&der).unwrap_err();
532-
#[cfg(feature = "secp256k1")]
533530
Secp256k1VerifyingKey::from_pem(&pem).unwrap_err();
534531

535532
// SimpleKeypair parses
@@ -539,7 +536,6 @@ mod test {
539536
assert_eq!(pem, from_pem.to_pem().unwrap());
540537
}
541538

542-
#[cfg(feature = "secp256r1")]
543539
#[proptest]
544540
fn secp256r1_pem_der(signer: Secp256r1PrivateKey) {
545541
// Private Key
@@ -591,7 +587,6 @@ mod test {
591587
assert_eq!(pem, from_pem.to_pem().unwrap());
592588
}
593589

594-
#[cfg(feature = "secp256k1")]
595590
#[proptest]
596591
fn secp256k1_pem_der(signer: Secp256k1PrivateKey) {
597592
// Private Key

crates/iota-sdk-types/src/crypto/passkey.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,13 +404,11 @@ impl proptest::arbitrary::Arbitrary for PasskeyAuthenticator {
404404
}
405405
}
406406

407-
#[cfg(test)]
407+
#[cfg(all(feature = "serde", test))]
408408
mod tests {
409-
#[cfg(feature = "serde")]
410409
use crate::UserSignature;
411410

412411
#[test]
413-
#[cfg(feature = "serde")]
414412
fn base64_encoded_passkey_user_signature() {
415413
let b64 = "BiVYDmenOnqS+thmz5m5SrZnWaKXZLVxgh+rri6LHXs25B0AAAAAnQF7InR5cGUiOiJ3ZWJhdXRobi5nZXQiLCAiY2hhbGxlbmdlIjoiQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQSIsIm9yaWdpbiI6Imh0dHA6Ly9sb2NhbGhvc3Q6NTE3MyIsImNyb3NzT3JpZ2luIjpmYWxzZSwgInVua25vd24iOiAidW5rbm93biJ9YgJMwqcOmZI7F/N+K5SMe4DRYCb4/cDWW68SFneSHoD2GxKKhksbpZ5rZpdrjSYABTCsFQQBpLORzTvbj4edWKd/AsEBeovrGvHR9Ku7critg6k7qvfFlPUngujXfEzXd8Eg";
416414

crates/iota-sdk-types/src/crypto/validator.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,13 @@ pub struct ValidatorSignature {
161161
pub signature: Bls12381Signature,
162162
}
163163

164-
#[cfg(test)]
164+
#[cfg(all(feature = "serde", test))]
165165
mod test {
166166
#[cfg(target_arch = "wasm32")]
167167
use wasm_bindgen_test::wasm_bindgen_test as test;
168168

169-
#[cfg(feature = "serde")]
170169
use super::*;
171170

172-
#[cfg(feature = "serde")]
173171
#[test]
174172
fn aggregated_signature_fixture() {
175173
use base64ct::{Base64, Encoding};

crates/iota-sdk-types/src/gas.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,16 +127,14 @@ impl std::fmt::Display for GasCostSummary {
127127
}
128128
}
129129

130-
#[cfg(test)]
130+
#[cfg(all(feature = "serde", test))]
131131
mod test {
132132
#[cfg(target_arch = "wasm32")]
133133
use wasm_bindgen_test::wasm_bindgen_test as test;
134134

135-
#[cfg(feature = "serde")]
136135
use super::*;
137136

138137
#[test]
139-
#[cfg(feature = "serde")]
140138
fn formats() {
141139
let actual = GasCostSummary {
142140
computation_cost: 42,

crates/iota-sdk-types/src/transaction/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ pub struct ChangeEpochV2 {
691691
/// write out the modules below. Modules are provided with the version they
692692
/// will be upgraded to, their modules in serialized form (which include
693693
/// their package ID), and a list of their transitive dependencies.
694-
#[cfg_attr(feature = "proptest", any(proptest::collection::size_range(0..=2).lift()))]
694+
#[cfg_attr(all(test, feature = "proptest"), any(proptest::collection::size_range(0..=2).lift()))]
695695
pub system_packages: Vec<SystemPackage>,
696696
}
697697

crates/iota-sdk-types/src/u256.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ mod test {
112112
assert_eq!(one_platform, U256::from_be(U256::from_digits(one_be)));
113113
}
114114

115-
#[proptest]
116115
#[cfg(feature = "proptest")]
116+
#[proptest]
117117
fn dont_crash_on_large_inputs(
118118
#[strategy(proptest::collection::vec(any::<u8>(), 33..1024))] bytes: Vec<u8>,
119119
) {
@@ -124,8 +124,8 @@ mod test {
124124
let _ = U256::from_str_radix(&radix10, 10);
125125
}
126126

127-
#[proptest]
128127
#[cfg(feature = "proptest")]
128+
#[proptest]
129129
fn valid_u256_strings(
130130
#[strategy(proptest::collection::vec(any::<u8>(), 1..=32))] bytes: Vec<u8>,
131131
) {

0 commit comments

Comments
 (0)