refactor: handle wallet balance errors consistently with a detailed output format

Author: cwarnerdev

tools/wasp-cli/authentication/login.go

@@ -40,7 +40,6 @@ func initSetTokenCmd() *cobra.Command {
 			err := format.PrintOutput(authOutput)
 
 			log.Check(err, "error formatting output")
-
 		},
 	}
 	waspcmd.WithWaspNodeFlag(cmd, &node)

tools/wasp-cli/format/wallet_balance_output.go

@@ -14,11 +14,23 @@ type WalletBalanceData struct {
 	Balances     []*iotajsonrpc.Balance `json:"balances"`
 }
 
+// WalletBalanceErrorData represents the data structure for wallet balance error cases
+type WalletBalanceErrorData struct {
+	AddressIndex uint32 `json:"addressIndex"`
+	Address      string `json:"address"`
+	Error        string `json:"error"`
+}
+
 // WalletBalanceOutput represents the output of wallet balance commands
 type WalletBalanceOutput struct {
 	BaseOutput[WalletBalanceData]
 }
 
+// WalletBalanceErrorOutput represents the output for wallet balance errors
+type WalletBalanceErrorOutput struct {
+	BaseOutput[WalletBalanceErrorData]
+}
+
 // NewWalletBalanceOutput creates a new wallet balance output
 func NewWalletBalanceOutput(addressIndex uint32, address string, balances []*iotajsonrpc.Balance, success bool) *WalletBalanceOutput {
 	status := "success"
@@ -43,14 +55,14 @@ func NewWalletBalanceSuccess(addressIndex uint32, address string, balances []*io
 }
 
 // NewWalletBalanceError creates an error wallet balance output
-func NewWalletBalanceError(addressIndex uint32, address string) *WalletBalanceOutput {
-	data := WalletBalanceData{
+func NewWalletBalanceError(addressIndex uint32, address string, errorMsg string) *WalletBalanceErrorOutput {
+	data := WalletBalanceErrorData{
 		AddressIndex: addressIndex,
 		Address:      address,
-		Balances:     []*iotajsonrpc.Balance{},
+		Error:        errorMsg,
 	}
 
-	return &WalletBalanceOutput{
+	return &WalletBalanceErrorOutput{
 		BaseOutput: NewBaseOutput("wallet_balance", "error", data),
 	}
 }
@@ -125,3 +137,58 @@ func (wbo *WalletBalanceOutput) GetBalanceForCoinType(coinType string) (string,
 func (wbo *WalletBalanceOutput) IsSuccess() bool {
 	return wbo.Status == "success"
 }
+
+// ToTable returns the wallet balance error output as table rows
+func (wbeo *WalletBalanceErrorOutput) ToTable() [][]string {
+	rows := [][]string{
+		{"Address Index", "Address"},
+		{strconv.FormatUint(uint64(wbeo.Data.AddressIndex), 10), wbeo.Data.Address},
+	}
+
+	// Add empty row for spacing
+	rows = append(rows, []string{"", ""})
+
+	// Add error information
+	rows = append(rows, []string{"Error", wbeo.Data.Error})
+
+	return rows
+}
+
+// Validate validates the wallet balance error output
+func (wbeo *WalletBalanceErrorOutput) Validate() error {
+	// Validate base output
+	if err := wbeo.BaseOutput.Validate(); err != nil {
+		return err
+	}
+
+	// Validate wallet balance error-specific fields
+	if wbeo.Data.Address == "" {
+		return fmt.Errorf("address cannot be empty for wallet balance error output")
+	}
+
+	if wbeo.Data.Error == "" {
+		return fmt.Errorf("error message cannot be empty for wallet balance error output")
+	}
+
+	return nil
+}
+
+// GetAddress returns the wallet address
+func (wbeo *WalletBalanceErrorOutput) GetAddress() string {
+	return wbeo.Data.Address
+}
+
+// GetAddressIndex returns the address index
+func (wbeo *WalletBalanceErrorOutput) GetAddressIndex() uint32 {
+	return wbeo.Data.AddressIndex
+}
+
+// GetError returns the error message
+func (wbeo *WalletBalanceErrorOutput) GetError() string {
+	return wbeo.Data.Error
+}
+
+// IsSuccess returns false since this is an error output
+func (wbeo *WalletBalanceErrorOutput) IsSuccess() bool {
+	return false
+}

tools/wasp-cli/wallet/info.go

@@ -39,7 +39,7 @@ func initBalanceCmd() *cobra.Command {
 			address := myWallet.Address()
 			balance, err := cliclients.L1Client().GetAllBalances(context.Background(), address.AsIotaAddress())
 			if err != nil {
-				balanceOutput := format.NewWalletBalanceError(myWallet.AddressIndex(), address.String())
+				balanceOutput := format.NewWalletBalanceError(myWallet.AddressIndex(), address.String(), err.Error())
 				formatErr := format.PrintOutput(balanceOutput)
 				if formatErr != nil {
 					log.Printf("Error formatting output: %v", formatErr)