PR Review

Author: lukasfrank

api/compute/v1alpha1/machine_types.go

@@ -130,7 +130,7 @@ type EmptyDiskVolumeSource struct {
 // Usually ephemeral (i.e. deleted when the surrounding entity is deleted), with
 // varying performance characteristics. Potentially not recoverable.
 type LocalDiskVolumeSource struct {
-	// SizeLimit is the total amount of local storage required for this EmptyDisk volume.
+	// SizeLimit is the total amount of local storage required for this LocalDisk volume.
 	// The default is nil which means that the limit is undefined.
 	SizeLimit *resource.Quantity `json:"sizeLimit,omitempty"`
 	// Image is the optional URL providing the operating system image of the machine.

broker/machinebroker/server/machine.go

@@ -149,7 +149,7 @@ func (s *Server) convertIronCoreVolume(
 			},
 		}
 	default:
-		return nil, fmt.Errorf("machine volume %#v does neither specify volume ref nor empty disk, nor local disk", ironcoreMachineVolume)
+		return nil, fmt.Errorf("machine volume %#v does neither specify volume ref nor local disk", ironcoreMachineVolume)
 	}
 
 	return &iri.Volume{

broker/machinebroker/server/machine_volume_detach.go

@@ -56,7 +56,7 @@ func (s *Server) DetachVolume(ctx context.Context, req *iri.DetachVolumeRequest)
 			return nil, fmt.Errorf("error deleting ironcore volume %s: %w", ironcoreVolumeName, err)
 		}
 	case ironcoreMachineVolume.LocalDisk != nil:
-		log.V(1).Info("No need to clean up empty disk")
+		log.V(1).Info("No need to clean up local disk")
 	default:
 		return nil, fmt.Errorf("unrecognized ironcore machine volume %#v", ironcoreMachineVolume)
 	}

internal/apis/compute/machine_types.go

@@ -118,7 +118,7 @@ type EmptyDiskVolumeSource struct {
 // Usually ephemeral (i.e. deleted when the surrounding entity is deleted), with
 // varying performance characteristics. Potentially not recoverable.
 type LocalDiskVolumeSource struct {
-	// SizeLimit is the total amount of local storage required for this EmptyDisk volume.
+	// SizeLimit is the total amount of local storage required for this LocalDisk volume.
 	// The default is nil which means that the limit is undefined.
 	SizeLimit *resource.Quantity
 	// Image is the optional URL providing the operating system image of the machine.