E2E code consolidations #1397
Merged
E2E code consolidations #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 80.55% 81.03% +0.47%
==========================================
Files 44 44
Lines 2299 2299
==========================================
+ Hits 1852 1863 +11
+ Misses 328 321 -7
+ Partials 119 115 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This code is very repetitive and verbose, extracting it to a common function allows the tests to be much more concise and readable, without affecting functionality. The main benefit of this is making the tests easier to read and maintain, and avoid repeating code (and making mistakes). Signed-off-by: Mike Kolesnik <[email protected]>
Most of the tests that await for the DeploymentAvailable condition do it on the control plane namespace for a Deployment. Extracting this specific case makes the tests even easier to read and understand. Signed-off-by: Mike Kolesnik <[email protected]>
Reuse CheckPodsReady and add a specific function CheckSamplePodsReady since most of the calls are on the sample namespace. Both checks are now in the `checks.go` file for logical consistency. Signed-off-by: Mike Kolesnik <[email protected]>
This is repetitive and verbose, extracting this makes the tests easier to read and maintain. Signed-off-by: Mike Kolesnik <[email protected]>
mkolesnik
force-pushed
the
e2e-code-consolidate
branch
from
31e1ed4 to
2cb5e6d
Compare
fjglira
approved these changes
Dec 2, 2025
Contributor
fjglira
left a comment
fjglira
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for this enhancement of the E2E framework
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Dec 2, 2025
* upstream/main: Fix update Istio version in docs for main readme (istio-ecosystem#1419) E2E code consolidations (istio-ecosystem#1397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR incorporates several changes that refactor the E2E tests and consolidate various checks that are very verbose and very repetitive.
By consolidating the checks into common functions, the test code becomes much more readable and thus easier to write and maintain.
Another benefit of using common functions is lower chance for errors due to copy/pasting the same code and tweaking it slightly.
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: