Skip to content

Commit eb062d4

Browse files
cipolleschimeta-codesync[bot]
authored andcommitted
Fix create-draft-release syntax error (facebook#54567)
Summary: Pull Request resolved: facebook#54567 This change fix a syntax error in the create-draft-release workflow. We were basically passing the Hermes and HermesV1 versions without wrapping them in `'`. JS was interpreting them as numbers and making a mess of the syntax. Wrapping them in `'` should fix the job. The commit was already picked in the release branch. ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D87244325 fbshipit-source-id: b115c233779b36a1b6b0462eb0a8ef60ceafce7c
1 parent 936141f commit eb062d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/create-draft-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
const {createDraftRelease} = require('./.github/workflow-scripts/createDraftRelease.js');
3838
const version = '${{ github.ref_name }}';
3939
const {isLatest} = require('./.github/workflow-scripts/publishTemplate.js');
40-
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', ${{ inputs.hermesVersion }}, ${{ inputs.hermesV1Version }})).id;
40+
return (await createDraftRelease(version, isLatest(), '${{secrets.REACT_NATIVE_BOT_GITHUB_TOKEN}}', '${{ inputs.hermesVersion }}', '${{ inputs.hermesV1Version }}')).id;
4141
result-encoding: string
4242
- name: Upload release assets for DotSlash
4343
uses: actions/github-script@v6

0 commit comments

Comments
 (0)