Merge pull request #3115 from pljones/options/pass-commandline-by-reference

pljones · web-flow · commit a9b5475d1c02 · 2023-09-27T09:24:31.000+01:00
Refactor: Pass "CommandLineOptions" to CSettings::Load by reference
diff --git a/src/settings.cpp b/src/settings.cpp
@@ -25,7 +25,7 @@
 #include "settings.h"
 
 /* Implementation *************************************************************/
-void CSettings::Load ( const QList<QString> CommandLineOptions )
+void CSettings::Load ( const QList<QString>& CommandLineOptions )
 {
     // prepare file name for loading initialization data from XML file and read
     // data from file if possible
diff --git a/src/settings.h b/src/settings.h
@@ -52,7 +52,7 @@ class CSettings : public QObject
         QObject::connect ( QCoreApplication::instance(), &QCoreApplication::aboutToQuit, this, &CSettings::OnAboutToQuit );
     }
 
-    void Load ( const QList<QString> CommandLineOptions );
+    void Load ( const QList<QString>& CommandLineOptions );
     void Save();
 
     // common settings

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`#include "settings.h"`
`26`	`26`
`27`	`27`	`/* Implementation *************************************************************/`
`28`		`-void CSettings::Load ( const QList<QString> CommandLineOptions )`
	`28`	`+void CSettings::Load ( const QList<QString>& CommandLineOptions )`
`29`	`29`	`{`
`30`	`30`	`// prepare file name for loading initialization data from XML file and read`
`31`	`31`	`// data from file if possible`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ class CSettings : public QObject`
`52`	`52`	`QObject::connect ( QCoreApplication::instance(), &QCoreApplication::aboutToQuit, this, &CSettings::OnAboutToQuit );`
`53`	`53`	`}`
`54`	`54`
`55`		`- void Load ( const QList<QString> CommandLineOptions );`
	`55`	`+ void Load ( const QList<QString>& CommandLineOptions );`
`56`	`56`	`void Save();`
`57`	`57`
`58`	`58`	`// common settings`