Skip to content

Commit f856347

Browse files
authored
Merge pull request #3324 from pljones/update-CONTRIBUTING-Qt
Update CONTRIBUTING.md for the minimum Qt version
2 parents bd117d9 + 1644fd3 commit f856347

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,17 @@ We support the following platforms and versions:
6060

6161
- **Windows 10** or later
6262
- **macOS 10.10** or later
63-
- **Ubuntu 20.04** or later, **Debian 11** or later, most Linux flavors with recent enough Qt versions. (Currently, it may still build on Ubuntu 18.04 and Debian 10, but the binaries built by Github will not run on those versions)
63+
- **Ubuntu 20.04** or later, **Debian 11** or later, most Linux flavors with recent enough Qt versions. (Currently, it may still build on Ubuntu 18.04 and Debian 10, but the binaries built by Github will not run on those versions.)
6464

6565
_While Android and iOS aren't officially supported, please don't break their builds._
6666

67-
Please try to avoid breaking any build by introducing platform-specific code. Check to see if any newly introduced Qt calls, parameters, properties or constants are available in the minimum supported Qt version, which is currently **5.9**. Note that code _style_ in a file may be Qt 4.x. While you should normally stick to existing style, if you make large-scale modifications, updating to Qt 5.9 style is recommended.
67+
Please try to avoid breaking any build by introducing platform-specific code. Check the Github builds all worked before raising a pull request.
68+
Check to see if any newly introduced Qt calls, parameters, properties or constants are available in the minimum supported Qt version, which is currently **5.12.2**. Note that code _style_ in a file may be Qt 4.x. While you should normally stick to existing style, if you make large-scale modifications, updating to Qt 5.12.2 style is recommended.
6869
Maintain C++11 compatibility throughout the code.
6970

7071
### Dependencies
7172

72-
If your code requires new dependencies, ensure that they are available on all supported platforms and that their inclusion has been discussed and approved.
73+
If your code requires new dependencies, ensure that they are available on all supported platforms and that their inclusion has been discussed and approved. Include the `AUTOBUILD: Please build all targets` tag in your pull request to confirm Github builds for all supported platforms are successful.
7374

7475
### User experience
7576

0 commit comments

Comments
 (0)