-
-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Labels
↗️ medium priorityThis issue is crucialThis issue is crucial✨ enhancementNew feature or request or improvementNew feature or request or improvementhacktoberfestRelated to hacktoberfestRelated to hacktoberfest
Description
The third iteration of the auth feature should focus on enhancing the OAuth flow and adding a signout/disconnect feature.
This is a follow up to the initial iterations...
- First Iteration - https://github.com/babblebey/jargons.dev/pull/8
- Second Iteration - https://github.com/babblebey/jargons.dev/pull/28
- OAuth App type refactoring - https://github.com/babblebey/jargons.dev/pull/33
Tasks
- Store OAuth Flow State Object in Cookies: Implement the todo that suggests storing the OAuth flow state object to cookies. This stored state should be compared with the
stateparam returned from the GitHub OAuth flow in thegithub/oauth/callbackhandler to prevent CSRF attacks.
Related Files
github/oauth/callback.jslib/actions/do-auth.js
Acceptance Criteria
- OAuth flow state object is stored in cookies and compared with the
stateparam. - Signout/disconnect feature is implemented and accessible through the
doAuthaction
Additional Notes
- Nothing much... just ask a question or share ideas, if you've got any 😉
Metadata
Metadata
Assignees
Labels
↗️ medium priorityThis issue is crucialThis issue is crucial✨ enhancementNew feature or request or improvementNew feature or request or improvementhacktoberfestRelated to hacktoberfestRelated to hacktoberfest