Attributes defined in jbang-catalog.json should but appended to the end of the command.

[bartoszpop]

Describe the bug
Attributes defined in jbang-catalog.json should but appended to the end of the command.

To Reproduce
The below jbang-catalog.json results with

1. Create the following jbang-catalog.json
   {
   "aliases": {
   "camel": {
   "script-ref": "org.apache.camel:camel-jbang-main:4.8.3",
   "main": "main.CamelJBang",
   "arguments": ["--quarkus-version=3.16.0"]
   }
   }
   }

2. run the command jbang camel@apache/camel run * --runtime=quarkus. It will produce jbang9236616212127187886.args

-classpath
"(...)"
main.CamelJBang
--quarkus-version=3.17.0 <--- this should go at the end
run
.camel-jbang
.camel-jbang-run
somefile.camel.yaml
jbang-catalog.json
--runtime=quarkus

JBang version
[jbang] [0:664] jbang version 0.121.0

[quintesse]

Well... I understand that for your use-case you want it like that, but I think this is actually worse (besides the possibility that we could break existing code). The current implementation is based on how aliases work in shells (bash, zsg, etc), where user supplied arguments are also appended to the end. Why? So the user can override a parameter supplied by the alias, if alias params are put at the end they would always have precedence and the user would be much more limited.

A possible work-around for this would be to allow the Camel CLI to get its quarkus version from a system property, eg:

{
   "aliases": {
      "camel": {
         "script-ref": "org.apache.camel:camel-jbang-main:4.8.3",
         "main": "main.CamelJBang",
         "arguments": [],
         "properties": {
            "quarkus.version": "3.17.0"
         }
      }
   }
}

So you'd get something like:

-classpath
"(...)"
-Dquarkus.version=3.17.0
main.CamelJBang
run
.camel-jbang
.camel-jbang-run
somefile.camel.yaml
jbang-catalog.json
--runtime=quarkus

(You would still allow "--quarkus-version" as well of course, so users can change it if they want to)

[quintesse]

Oh, I just thought of another work-around.... except that it doesn't work, which does seem a bug. This is what I thought you could do:

Create 2 aliases, with one referring to the other, eg:

{
   "aliases": {
      "camel": {
         "script-ref": "camel-run",
         "arguments": ["--quarkus-version=3.16.0"]
      },
      "camel-run": {
         "script-ref": "org.apache.camel:camel-jbang-main:4.8.3",
         "main": "main.CamelJBang",
         "arguments": ["run"]
      }
   }
}

But it turns out the arguments of one alias overwrite the arguments from the other, which is unfortunate and I don't think that's correct. So I'll try to fix that.

[quintesse]

Created PR #1913

[bartoszpop]

@quintesse thank you for the fix.