Skip to content

Commit 45b408a

Browse files
committed
Remove dependency on internal m2e buildcontext
Signed-off-by: Fred Bricon <[email protected]>
1 parent e16dc62 commit 45b408a

File tree

4 files changed

+85
-11
lines changed

4 files changed

+85
-11
lines changed

org.jboss.tools.m2e.wro4j.core/META-INF/MANIFEST.MF

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ Bundle-Vendor: Red Hat, Inc.
77
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
88
Require-Bundle: org.eclipse.core.resources;bundle-version="3.4.0",
99
org.eclipse.core.runtime;bundle-version="3.4.0",
10-
org.eclipse.m2e.jdt;bundle-version="[1.5.0,2.0)",
11-
org.eclipse.m2e.core;bundle-version="[1.5.0,2.0)",
12-
org.eclipse.m2e.maven.runtime;bundle-version="[1.5.0,2.0)"
10+
org.eclipse.m2e.jdt;bundle-version="[1.4.0,2.0)",
11+
org.eclipse.m2e.core;bundle-version="[1.4.0,2.0)",
12+
org.eclipse.m2e.maven.runtime;bundle-version="[1.4.0,2.0)"

org.jboss.tools.m2e.wro4j.core/src/org/jboss/tools/m2e/wro4j/internal/Wro4jBuildParticipant.java

Lines changed: 79 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010

1111
import java.io.File;
1212
import java.io.IOException;
13+
import java.io.OutputStream;
1314
import java.util.ArrayList;
1415
import java.util.Arrays;
1516
import java.util.Collection;
1617
import java.util.List;
17-
import java.util.Map;
1818
import java.util.Set;
1919
import java.util.regex.Matcher;
2020
import java.util.regex.Pattern;
@@ -33,8 +33,6 @@
3333
import org.eclipse.core.runtime.Path;
3434
import org.eclipse.m2e.core.MavenPlugin;
3535
import org.eclipse.m2e.core.embedder.IMaven;
36-
import org.eclipse.m2e.core.internal.builder.MavenBuilderImpl;
37-
import org.eclipse.m2e.core.internal.builder.plexusbuildapi.EclipseBuildContext;
3836
import org.eclipse.m2e.core.project.IMavenProjectFacade;
3937
import org.eclipse.m2e.core.project.MavenProjectUtils;
4038
import org.eclipse.m2e.core.project.configurator.MojoExecutionBuildParticipant;
@@ -93,8 +91,7 @@ public Set<IProject> build(int kind, IProgressMonitor monitor)
9391
if (isPomModified() || interestingFileChangeDetected(includedFiles, WRO4J_FILES_PATTERN)) {
9492
//treat as new full build as wro4j only checks for classic resources changes during incremental builds
9593
IProject project = getMavenProjectFacade().getProject();
96-
Map<String, Object> contextMap = (Map<String, Object>) project.getSessionProperty(MavenBuilderImpl.BUILD_CONTEXT_KEY);
97-
currentBuildContext = new EclipseBuildContext(project, contextMap);
94+
currentBuildContext = new CleanBuildContext(originalBuildContext);
9895
} else if (!interestingFileChangeDetected(includedFiles, WEB_RESOURCES_PATTERN)) {
9996
return null;
10097
}
@@ -330,4 +327,81 @@ private boolean notCleanFullBuild(int kind) {
330327
&& IncrementalProjectBuilder.CLEAN_BUILD != kind;
331328
}
332329

330+
private static class CleanBuildContext implements BuildContext {
331+
332+
private BuildContext originalContext;
333+
334+
CleanBuildContext(BuildContext originalContext) {
335+
this.originalContext = originalContext;
336+
}
337+
338+
public boolean hasDelta(String relpath) {
339+
return true;
340+
}
341+
342+
public boolean hasDelta(File file) {
343+
return true;
344+
}
345+
346+
public boolean hasDelta(List relpaths) {
347+
return true;
348+
}
349+
350+
public void refresh(File file) {
351+
originalContext.refresh(file);
352+
}
353+
354+
public OutputStream newFileOutputStream(File file) throws IOException {
355+
return originalContext.newFileOutputStream(file);
356+
}
357+
358+
public Scanner newScanner(File basedir) {
359+
return originalContext.newScanner(basedir);
360+
}
361+
362+
public Scanner newDeleteScanner(File basedir) {
363+
return originalContext.newDeleteScanner(basedir);
364+
}
365+
366+
public Scanner newScanner(File basedir, boolean ignoreDelta) {
367+
return originalContext.newScanner(basedir, ignoreDelta);
368+
}
369+
370+
public boolean isIncremental() {
371+
return false;
372+
}
373+
374+
public void setValue(String key, Object value) {
375+
originalContext.setValue(key, value);
376+
}
377+
378+
public Object getValue(String key) {
379+
return originalContext.getValue(key);
380+
}
381+
382+
public void addWarning(File file, int line, int column, String message,
383+
Throwable cause) {
384+
originalContext.addWarning(file, line, column, message, cause);
385+
}
386+
387+
public void addError(File file, int line, int column, String message,
388+
Throwable cause) {
389+
originalContext.addError(file, line, column, message, cause);
390+
}
391+
392+
public void addMessage(File file, int line, int column, String message,
393+
int severity, Throwable cause) {
394+
originalContext.addMessage(file, line, column, message, severity, cause);
395+
}
396+
397+
public void removeMessages(File file) {
398+
originalContext.removeMessages(file);
399+
}
400+
401+
public boolean isUptodate(File target, File source) {
402+
return false;
403+
}
404+
405+
}
406+
333407
}

org.jboss.tools.m2e.wro4j.tests/META-INF/MANIFEST.MF

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Bundle-Name: WRO4J Tests Plug-in
44
Bundle-SymbolicName: org.jboss.tools.m2e.wro4j.tests
55
Bundle-Version: 1.1.0.qualifier
66
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
7-
Require-Bundle: org.eclipse.m2e.tests.common;bundle-version="[1.5.0,2.0.0)",
8-
org.eclipse.m2e.core;bundle-version="[1.5.0,2.0.0)",
7+
Require-Bundle: org.eclipse.m2e.tests.common;bundle-version="[1.4.0,2.0.0)",
8+
org.eclipse.m2e.core;bundle-version="[1.4.0,2.0.0)",
99
org.eclipse.core.resources;bundle-version="3.4.2",
1010
org.eclipse.core.runtime;bundle-version="3.4.0",
1111
org.eclipse.jdt.core;bundle-version="3.4.4",

org.jboss.tools.m2e.wro4j.ui/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ Bundle-SymbolicName: org.jboss.tools.m2e.wro4j.ui;singleton:=true
55
Bundle-Version: 1.1.0.qualifier
66
Bundle-Vendor: Red Hat, Inc.
77
Bundle-RequiredExecutionEnvironment: JavaSE-1.6, JavaSE-1.7
8-
Require-Bundle: org.eclipse.m2e.editor.xml;bundle-version="[1.5.0,2.0.0)"
8+
Require-Bundle: org.eclipse.m2e.editor.xml;bundle-version="[1.4.0,2.0.0)"

0 commit comments

Comments
 (0)