Skip to content

Commit f70e44e

Browse files
authored
Merge pull request #1018 from Inform-Software/use-jdk11-image
Use jdk11 agent when Jenkins is running on jdk11
2 parents 8742870 + 502f3cc commit f70e44e

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
import io.fabric8.kubernetes.api.model.VolumeMount;
7272
import io.fabric8.kubernetes.api.model.VolumeMountBuilder;
7373
import io.fabric8.kubernetes.client.utils.Serialization;
74-
74+
import io.jenkins.lib.versionnumber.JavaSpecificationVersion;
7575
import jenkins.model.Jenkins;
7676

7777
import javax.annotation.CheckForNull;
@@ -103,7 +103,7 @@ public class PodTemplateBuilder {
103103
.getProperty(PodTemplateStepExecution.class.getName() + ".dockerRegistryPrefix");
104104
@Restricted(NoExternalUse.class)
105105
static final String DEFAULT_JNLP_IMAGE = System
106-
.getProperty(PodTemplateStepExecution.class.getName() + ".defaultImage", "jenkins/inbound-agent:4.3-4");
106+
.getProperty(PodTemplateStepExecution.class.getName() + ".defaultImage", getDefaultImageName());
107107

108108
static final String DEFAULT_JNLP_CONTAINER_MEMORY_REQUEST = System
109109
.getProperty(PodTemplateStepExecution.class.getName() + ".defaultContainer.defaultMemoryRequest", "256Mi");
@@ -137,6 +137,15 @@ public PodTemplateBuilder(PodTemplate template, KubernetesSlave agent) {
137137
this.cloud = agent.getKubernetesCloud();
138138
}
139139

140+
private static String getDefaultImageName() {
141+
// TODO: Reverse logic after inbound-agent:4.9-1
142+
String name = "jenkins/inbound-agent:4.3-4";
143+
if (JavaSpecificationVersion.forCurrentJVM().isNewerThanOrEqualTo(JavaSpecificationVersion.JAVA_11)) {
144+
name = name + "-jdk11";
145+
}
146+
return name;
147+
}
148+
140149
public PodTemplateBuilder withSlave(@Nonnull KubernetesSlave slave) {
141150
this.agent = slave;
142151
this.cloud = slave.getKubernetesCloud();

0 commit comments

Comments
 (0)