Fix colored output (hyperledger#9326)

* Fix colored output in terminal

Signed-off-by: Jintu Das <[email protected]>

* Update CHANGELOG

Signed-off-by: Jintu Das <[email protected]>

* Change logger output to out instead of err

Signed-off-by: Jintu Das <[email protected]>

* move changelog entry to unreleased

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Jintu Das <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -24,6 +24,7 @@
 - Use Eclipse Temurin OpenJDK JRE in Besu docker image [#9392](https://github.com/hyperledger/besu/pull/9392)
 
 ### Bug fixes
+- Fix loss of colored output in terminal when using `--color-enabled=true` option [#8908](https://github.com/hyperledger/besu/issues/8908)
 
 ## 25.11.0
 

app/src/main/java/org/hyperledger/besu/cli/logging/XmlExtensionConfiguration.java

@@ -62,7 +62,7 @@ public Configuration reconfigure() {
             new XmlExtensionConfiguration(
                 refreshedParent.getLoggerContext(),
                 refreshedParent.getConfigurationSource().resetInputStream());
-        createConsoleAppender();
+        refreshed.createConsoleAppender();
         return refreshed;
       } catch (final IOException e) {
         LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME)
@@ -90,11 +90,12 @@ private void createConsoleAppender() {
       return;
     }
 
+    final boolean colorEnabled = getColorEnabled();
     final PatternLayout patternLayout =
         PatternLayout.newBuilder()
             .withConfiguration(this)
-            .withDisableAnsi(!BesuCommand.getColorEnabled().orElse(!noColorSet()))
-            .withNoConsoleNoAnsi(!BesuCommand.getColorEnabled().orElse(false))
+            .withDisableAnsi(!colorEnabled)
+            .withNoConsoleNoAnsi(!colorEnabled)
             .withPattern(
                 String.join(
                     SEP,
@@ -105,11 +106,29 @@ private void createConsoleAppender() {
                     colorize("%msgc%n%throwable")))
             .build();
     final ConsoleAppender consoleAppender =
-        ConsoleAppender.newBuilder().setName("Console").setLayout(patternLayout).build();
+        ConsoleAppender.newBuilder()
+            .setName("Console")
+            .setTarget(ConsoleAppender.Target.SYSTEM_OUT)
+            .setLayout(patternLayout)
+            .build();
     consoleAppender.start();
+
+    // Remove existing Console appender if present to avoid duplicate output
+    if (this.getRootLogger().getAppenders().containsKey("Console")) {
+      this.getRootLogger().removeAppender("Console");
+    }
+
     this.getRootLogger().addAppender(consoleAppender, null, null);
   }
 
+  private boolean getColorEnabled() {
+    try {
+      return BesuCommand.getColorEnabled().orElse(!noColorSet());
+    } catch (NoClassDefFoundError | ExceptionInInitializerError e) {
+      return !noColorSet();
+    }
+  }
+
   private static boolean noColorSet() {
     return System.getenv("NO_COLOR") != null;
   }