Skip to content

Conversation

@mnahkies
Copy link

  • upgrades remarkable to the latest version, which removes some problematic dependencies causing CVE's to be flagged by automated scanners
  • bumps the minimum nodejs version accordingly
  • aims to be a minimal change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to replace this with a github actions workflow

require('minimist');
require('mixin-deep', 'merge');
require('object.pick', 'pick');
require('remarkable', 'Remarkable');
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When continuing to use lazy-cache I got a Remarkable is not a constructor error. I'm not sure that there is much value in lazy-cache for remarkable when it's doing the majority of the heavy lifting for this module.

mnahkies added a commit to mnahkies/ng-qrcode that referenced this pull request Oct 26, 2025
`markdown-toc` appears somewhat abandoned, with a PR I raised to
upgrade `remarkable` going unlooked at ~6 months.

(ref: jonschlinkert/markdown-toc#199)

replace it with `remark` / `remark-toc` to clear CVE warnings.
mnahkies added a commit to mnahkies/ng-qrcode that referenced this pull request Oct 26, 2025
`markdown-toc` appears somewhat abandoned, with a PR I raised to upgrade
`remarkable` going unlooked at ~6 months.

(ref: jonschlinkert/markdown-toc#199)

replace it with `remark` / `remark-toc` to clear CVE warnings.
mnahkies added a commit to mnahkies/openapi-code-generator that referenced this pull request Oct 26, 2025
`markdown-toc` appears somewhat abandoned, with a PR I raised to upgrade `remarkable` going unlooked at ~6 months.

(ref: jonschlinkert/markdown-toc#199)

replace it with `remark` / `remark-toc` to clear CVE warnings.
mnahkies added a commit to mnahkies/openapi-code-generator that referenced this pull request Oct 26, 2025
`markdown-toc` appears somewhat abandoned, with a PR I raised to upgrade
`remarkable` going unlooked at ~6 months.

(ref: jonschlinkert/markdown-toc#199)

replace it with `remark` / `remark-toc` to clear CVE warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant