fix: newline issues with tests

Author: jspaezp

mkquartodocs/extension.py

@@ -90,6 +90,9 @@ def _trim_line(
     def get_lines_content(self, start: Cursor, end: Cursor) -> list[str]:
         # TODO ... this is an off-by 1 error nightmare ...
         # Some unit testing might be really worth it ...
+        if start == end:
+            return []
+
         if start.line == end.line:
             return [self._trim_line(self.lines[start.line], start=start, end=end)]
 
@@ -311,7 +314,6 @@ def _into_output_lines_cell(self, file_content: FileContent) -> list[str]:
         if isinstance(self.end, UnknownEnd):
             raise ValueError(f"BlockContext {self} has no end")
         out = []
-        out.append("\n\n")
         last_end = self.start.advance_line(1)
         tmp = self.find_inner_block(file_content, context=[], start=last_end)
         while tmp is not None:
@@ -323,7 +325,6 @@ def _into_output_lines_cell(self, file_content: FileContent) -> list[str]:
             tmp = self.find_inner_block(file_content, context=[], start=last_end)
 
         out.extend(file_content.get_lines_content(last_end, self.end.advance_line(-1)))
-        out.append("\n\n")
 
         return out
 
@@ -341,7 +342,7 @@ def _into_output_lines_cell_elem(self, file_content: FileContent) -> list[str]:
             )
 
         out.append(admon_candidates[0])
-        out.append("\n")
+        out.append("")
 
         internal = []
         last_end = self.start.advance_line(1)
@@ -376,7 +377,7 @@ def _into_output_lines_cell_elem(self, file_content: FileContent) -> list[str]:
             file_content.get_lines_content(last_end, self.end.advance_line(0))
         )
         out.extend([" " * 4 + line for line in internal])
-        out.append("\n\n")
+        out.append("")
 
         return out
 
@@ -387,7 +388,6 @@ def _into_output_lines_codeblock(
         if isinstance(self.end, UnknownEnd):
             raise ValueError(f"BlockContext {self} has no end")
         out = []
-        out.append("\n\n")
         language = ""
         if self.attributes:
             language = self.attributes[0]
@@ -403,7 +403,6 @@ def _into_output_lines_codeblock(
 
         out.extend(file_content.get_lines_content(last_end, self.end.advance_line(0)))
         out.append(f"{self.delimiter}")
-        out.append("\n\n")
         return out
 
 

tests/test_preprocessor.py

@@ -32,14 +32,18 @@
 """
 
 EXAMPLE_OUTPUT_FILE = """
-``` {.python .cell-code}
+```python
 import warnings
 warnings.warn("This is a warning")
+
 ```
 
-!!! warning "stderr"
-    ... UserWarning: This is a warning
-      warnings.warn("This is a warning")
+
+
+???+ warning "stderr"
+
+        ... UserWarning: This is a warning
+          warnings.warn("This is a warning")
 """
 
 
@@ -49,24 +53,14 @@ def test_conversion():
     # Right now I write a lot of ... unnecessary
     # newlines to be safe but I could trim it ...
     assert out == [
-        "\n\n",
-        "",
         '???+ note "output"',
-        "\n",
-        "    ",
-        "\n\n",
         "",
-        "\n\n",
         "",
-        "\n\n",
         "",
-        "\n\n",
-        "```python",
         "",
+        "```python",
         "```",
-        "\n\n",
         "",
-        "\n\n",
         "",
     ]