Update

Author: odow

src/Bridges/Constraint/bridges/IndicatorToMILPBridge.jl

@@ -126,9 +126,6 @@ function MOI.delete(
     model::MOI.ModelLike,
     bridge::IndicatorToMILPBridge{T},
 ) where {T}
-    if bridge.slack === nothing
-        return  # final_touch not called, so we can safely skip
-    end
     MOI.delete.(model, bridge.slack_bounds)
     MOI.delete(model, bridge.constraint)
     MOI.delete(model, bridge.slack::MOI.VariableIndex)

src/Bridges/Constraint/bridges/RSOCtoSOCBridge.jl

@@ -59,6 +59,13 @@ end
 
 function MOI.Bridges.map_function(::Type{<:RSOCtoSOCBridge{T}}, func) where {T}
     scalars = MOI.Utilities.eachscalar(func)
+    if MOI.dimension(set) < 2
+        err = DimensionMismatch(
+            "Unable to reformulate a `RotatedSecondOrderCone` into a " *
+            "`SecondOrderCone` because the output dimension is too small",
+        )
+        throw(err)
+    end
     t, u, x = scalars[1], scalars[2], scalars[3:end]
     ts = MOI.Utilities.operate!(/, T, t, sqrt(T(2)))
     us = MOI.Utilities.operate!(/, T, u, sqrt(T(2)))

src/Bridges/Constraint/bridges/SOCtoPSDBridge.jl

@@ -257,10 +257,11 @@ end
 function MOI.Bridges.map_function(::Type{<:RSOCtoPSDBridge{T}}, func) where {T}
     scalars = MOI.Utilities.eachscalar(func)
     if length(scalars) < 2
-        error(
+        err = DimensionMismatch(
             "Unable to bridge RotatedSecondOrderCone to PSD because the ",
             "dimension is too small: got $(length(scalars)), expected >= 2.",
         )
+        throw(err)
     elseif length(scalars) == 2
         return func
     end

src/Bridges/Constraint/bridges/SOCtoRSOCBridge.jl

@@ -50,13 +50,6 @@ function MOI.Bridges.map_set(
     ::Type{<:SOCtoRSOCBridge},
     set::MOI.SecondOrderCone,
 )
-    if MOI.dimension(set) == 1
-        error(
-            "Unable to reformulate a `SecondOrderCone` into a " *
-            "`RotatedSecondOrderCone` because the dimension of `1` is too " *
-            "small",
-        )
-    end
     return MOI.RotatedSecondOrderCone(MOI.dimension(set))
 end
 
@@ -69,6 +62,14 @@ end
 
 function MOI.Bridges.map_function(::Type{<:SOCtoRSOCBridge{T}}, func) where {T}
     scalars = MOI.Utilities.eachscalar(func)
+    if length(scalars) < 2
+        err = DimensionMismatch(
+            "Unable to reformulate a `SecondOrderCone` into a " *
+            "`RotatedSecondOrderCone` because the output dimension is too " *
+            "small",
+        )
+        throw(err)
+    end
     t, u, x = scalars[1], scalars[2], scalars[3:end]
     ts = MOI.Utilities.operate!(/, T, t, sqrt(T(2)))
     us = MOI.Utilities.operate!(/, T, u, sqrt(T(2)))

src/Bridges/Constraint/bridges/SOS1ToMILPBridge.jl

@@ -116,9 +116,6 @@ function MOI.get(::MOI.ModelLike, ::MOI.ConstraintSet, bridge::SOS1ToMILPBridge)
 end
 
 function MOI.delete(model::MOI.ModelLike, bridge::SOS1ToMILPBridge)
-    if isempty(bridge.variables)
-        return
-    end
     MOI.delete(model, bridge.equal_to)
     for ci in bridge.less_than
         MOI.delete(model, ci)

src/Bridges/Constraint/bridges/SOS2ToMILPBridge.jl

@@ -116,9 +116,6 @@ function MOI.get(::MOI.ModelLike, ::MOI.ConstraintSet, bridge::SOS2ToMILPBridge)
 end
 
 function MOI.delete(model::MOI.ModelLike, bridge::SOS2ToMILPBridge)
-    if isempty(bridge.variables)
-        return
-    end
     MOI.delete(model, bridge.equal_to)
     for ci in bridge.less_than
         MOI.delete(model, ci)

test/Bridges/Constraint/RSOCBridge.jl

@@ -179,6 +179,26 @@ function test_runtests()
     return
 end
 
+function test_dimension_mismatch_SOCR()
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
+    model = MOI.Bridges.Constraint.SOCR{Float64}(inner)
+    @test_throws(
+        DimensionMismatch,
+        MOI.add_constrained_variables(model, MOI.SecondOrderCone(1)),
+    )
+    return
+end
+
+function test_dimension_mismatch_RSOC()
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
+    model = MOI.Bridges.Constraint.RSOC{Float64}(inner)
+    @test_throws(
+        DimensionMismatch,
+        MOI.add_constrained_variables(model, MOI.RotatedSecondOrderCone(1)),
+    )
+    return
+end
+
 end  # module
 
 TestConstraintRSOC.runtests()

test/Bridges/Constraint/SOCtoPSDBridge.jl

@@ -231,6 +231,16 @@ function test_bridging_cost_RSOCtoPSD()
     return
 end
 
+function test_dimension_mismatch_RSOC_to_PSD()
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
+    model = MOI.Bridges.Constraint.RSOCtoPSD{Float64}(inner)
+    @test_throws(
+        DimensionMismatch,
+        MOI.add_constrained_variables(model, MOI.RotatedSecondOrderCone(1)),
+    )
+    return
+end
+
 end  # module
 
 TestConstraintSOCtoPSD.runtests()

test/Bridges/Constraint/ScalarSlackBridge.jl

@@ -411,6 +411,21 @@ function test_runtests()
     return
 end
 
+function test_basis_status()
+    inner = MOI.Utilities.MockOptimizer(
+        MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}()),
+    )
+    model = MOI.Bridges.Constraint.ScalarSlack{Float64}(inner)
+    x = MOI.add_variable(model)
+    c = MOI.add_constraint(model, 1.0 * x, MOI.GreaterThan(1.0))
+    y = MOI.get(inner, MOI.ListOfVariableIndices())
+    MOI.set.(inner, MOI.VariableBasisStatus(), y, MOI.BASIC)
+    @test MOI.get(model, MOI.ConstraintBasisStatus(), c) == MOI.BASIC
+    d = MOI.add_constraint(model, 1.0 * x, MOI.Interval(1.0, 2.0))
+    @test MOI.get(model, MOI.ConstraintBasisStatus(), c) == MOI.BASIC
+    return
+end
+
 end  # module
 
 TestConstraintSlack.runtests()

test/Bridges/Constraint/SplitIntervalBridge.jl

@@ -499,6 +499,33 @@ function test_runtests_vector()
     return
 end
 
+function test_get_function()
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
+    model = MOI.Bridges.Constraint.SplitInterval{Float64}(inner)
+    x = MOI.add_variable(model)
+    c = MOI.add_constraint(model, 1.0 * x, MOI.Interval(-Inf, Inf))
+    @test MOI.get(model, MOI.ConstraintFunction(), c) ≈ 1.0 * x
+    return
+end
+
+function test_modify_set()
+    inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{Float64}())
+    model = MOI.Bridges.Constraint.SplitInterval{Float64}(inner)
+    x = MOI.add_variable(model)
+    c = MOI.add_constraint(model, 1.0 * x, MOI.Interval(-Inf, Inf))
+    for set in [
+        MOI.Interval(-Inf, Inf),
+        MOI.Interval(1.0, 2.0),
+        MOI.Interval(2.0, 3.0),
+        MOI.Interval(-Inf, Inf),
+    ]
+        MOI.set(model, MOI.ConstraintSet(), c, set)
+        @test MOI.get(model, MOI.ConstraintSet(), c) == set
+        @test MOI.get(model, MOI.ConstraintFunction(), c) ≈ 1.0 * x
+    end
+    return
+end
+
 end  # module
 
 TestConstraintSplitInterval.runtests()