[FileFormats] fix writing unsupported variable types (#2654)

Author: odow

src/FileFormats/LP/LP.jl

@@ -46,6 +46,14 @@ MOI.Utilities.@model(
     (MOI.VectorAffineFunction,)
 )
 
+function MOI.supports_constraint(
+    ::Model,
+    ::Type{MOI.VariableIndex},
+    ::Type{<:Union{MOI.Parameter,MOI.Semicontinuous,MOI.Semiinteger}},
+)
+    return false
+end
+
 function MOI.supports_constraint(
     ::Model{T},
     ::Type{MOI.VectorAffineFunction{T}},

src/FileFormats/MPS/MPS.jl

@@ -74,6 +74,14 @@ function MOI.supports_constraint(
     return false
 end
 
+function MOI.supports_constraint(
+    ::Model,
+    ::Type{MOI.VariableIndex},
+    ::Type{<:Union{MOI.Parameter,MOI.Semicontinuous,MOI.Semiinteger}},
+)
+    return false
+end
+
 function MOI.supports_constraint(
     ::Model{T},
     ::Type{MOI.VectorOfVariables},

test/FileFormats/CBF/CBF.jl

@@ -699,6 +699,23 @@ function test_supports_quadratic_objective()
     return
 end
 
+function test_unsupported_variable_types()
+    model = CBF.Model()
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Parameter(2.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semicontinuous(2.0, 3.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semiinteger(2.0, 3.0)),
+    )
+    return
+end
+
 end  # module
 
 TestCBF.runtests()

test/FileFormats/LP/LP.jl

@@ -1113,6 +1113,23 @@ function test_unable_to_parse_bound()
     return
 end
 
+function test_unsupported_variable_types()
+    model = LP.Model()
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Parameter(2.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semicontinuous(2.0, 3.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semiinteger(2.0, 3.0)),
+    )
+    return
+end
+
 end  # module
 
 TestLP.runtests()

test/FileFormats/MPS/MPS.jl

@@ -1533,6 +1533,23 @@ function test_malformed_indicator()
     return
 end
 
+function test_unsupported_variable_types()
+    model = MPS.Model()
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Parameter(2.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semicontinuous(2.0, 3.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semiinteger(2.0, 3.0)),
+    )
+    return
+end
+
 end  # TestMPS
 
 TestMPS.runtests()

test/FileFormats/NL/NL.jl

@@ -6,10 +6,21 @@
 
 module TestNLModel
 
+using Test
+
 import MathOptInterface as MOI
-const NL = MOI.FileFormats.NL
+import MathOptInterface.FileFormats: NL
 
-using Test
+function runtests()
+    for name in names(@__MODULE__; all = true)
+        if startswith("$(name)", "test_")
+            @testset "$(name)" begin
+                getfield(@__MODULE__, name)()
+            end
+        end
+    end
+    return
+end
 
 function _test_nlexpr(
     expr::NL._NLExpr,
@@ -1352,14 +1363,18 @@ function test_copy_name_issue_2445()
     return
 end
 
-function runtests()
-    for name in names(@__MODULE__; all = true)
-        if startswith("$(name)", "test_")
-            @testset "$(name)" begin
-                getfield(@__MODULE__, name)()
-            end
-        end
+function test_unsupported_variable_types()
+    for set in (
+        MOI.Parameter(2.0),
+        MOI.Semicontinuous(2.0, 3.0),
+        MOI.Semiinteger(2.0, 3.0),
+    )
+        src = MOI.Utilities.Model{Float64}()
+        MOI.add_constrained_variable(src, set)
+        dest = NL.Model()
+        @test_throws MOI.UnsupportedConstraint MOI.copy_to(dest, src)
     end
+    return
 end
 
 end

test/FileFormats/SDPA/SDPA.jl

@@ -363,6 +363,23 @@ function test_integer_before_variables()
     return
 end
 
+function test_unsupported_variable_types()
+    model = SDPA.Model()
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Parameter(2.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semicontinuous(2.0, 3.0)),
+    )
+    @test_throws(
+        MOI.UnsupportedConstraint,
+        MOI.add_constrained_variable(model, MOI.Semiinteger(2.0, 3.0)),
+    )
+    return
+end
+
 end  # module
 
 TestSDPA.runtests()