update

Author: odow

src/Nonlinear/SymbolicAD/SymbolicAD.jl

@@ -89,10 +89,7 @@ end
 function simplify!(f::MOI.ScalarQuadraticFunction{T}) where {T}
     f = MOI.Utilities.canonicalize!(f)
     if isempty(f.quadratic_terms)
-        if isempty(f.affine_terms)
-            return f.constant
-        end
-        return MOI.ScalarAffineFunction(f.affine_terms, f.constant)
+        return simplify!(MOI.ScalarAffineFunction(f.affine_terms, f.constant))
     end
     return f
 end

test/Nonlinear/SymbolicAD.jl

@@ -46,8 +46,8 @@ function test_derivative()
         # derivative(f::MOI.ScalarQuadraticFunction{T}, x::MOI.VariableIndex)
         convert(MOI.ScalarQuadraticFunction{Float64}, 1.0 * x)=>1.0,
         convert(MOI.ScalarQuadraticFunction{Float64}, 1.0 * x + 0.0 * y)=>1.0,
-        1.0*x*y=>1.0*y,
-        1.0*y*x=>1.0*y,
+        1.0*x*y=>y,
+        1.0*y*x=>y,
         1.0*x*x=>2.0*x,
         1.0*x*x+3.0*x+4.0=>2.0*x+3.0,
         2.0*x*x-2.0*x+1.0=>4.0*x-2.0,