Enable LexicographicalAnnotationListing

Author: Vincent Potucek

gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts

@@ -42,7 +42,6 @@ tasks.withType<JavaCompile>().configureEach {
 				"FormatStringConcatenation",
 				"IdentityConversion",
 				"LexicographicalAnnotationAttributeListing", // We don`t want to use this: https://github.com/junit-team/junit-framework/pull/5043#pullrequestreview-3330615838
-				"LexicographicalAnnotationListing",
 				"MissingTestCall",
 				"NestedOptionals",
 				"NonStaticImport",
@@ -52,6 +51,7 @@ tasks.withType<JavaCompile>().configureEach {
 				"TimeZoneUsage",
 			)
 			error(
+				"LexicographicalAnnotationListing",
 				"PackageLocation",
 				"RedundantStringConversion",
 				"RedundantStringEscape",

junit-jupiter-api/src/main/java/org/junit/jupiter/api/AfterAll.java

@@ -91,9 +91,9 @@
  * @see TestFactory
  * @see TestInstance
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = STABLE, since = "5.0")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
 public @interface AfterAll {
 }

junit-jupiter-api/src/main/java/org/junit/jupiter/api/AfterEach.java

@@ -84,9 +84,9 @@
  * @see TestFactory
  * @see TestTemplate
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = STABLE, since = "5.0")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
 public @interface AfterEach {
 }

junit-jupiter-api/src/main/java/org/junit/jupiter/api/Assertions.java

@@ -3718,8 +3718,8 @@ public static <T> T assertInstanceOf(Class<T> expectedType, @Nullable Object act
 	 *
 	 * @since 5.8
 	 */
-	@Contract("_, null, _ -> fail")
 	@API(status = STABLE, since = "5.10")
+	@Contract("_, null, _ -> fail")
 	public static <T> T assertInstanceOf(Class<T> expectedType, @Nullable Object actualValue,
 			Supplier<@Nullable String> messageSupplier) {
 		return AssertInstanceOf.assertInstanceOf(expectedType, actualValue, messageSupplier);

junit-jupiter-api/src/main/java/org/junit/jupiter/api/Assumptions.java

@@ -284,8 +284,8 @@ public static void assumingThat(boolean assumption, Executable executable) {
 	 * @throws TestAbortedException always
 	 * @since 5.9
 	 */
-	@Contract(" -> fail")
 	@API(status = STABLE, since = "5.9")
+	@Contract(" -> fail")
 	@SuppressWarnings("TypeParameterUnusedInFormals")
 	public static <V> V abort() {
 		throw new TestAbortedException();
@@ -309,8 +309,8 @@ public static <V> V abort() {
 	 * @throws TestAbortedException always
 	 * @since 5.9
 	 */
-	@Contract("_ -> fail")
 	@API(status = STABLE, since = "5.9")
+	@Contract("_ -> fail")
 	@SuppressWarnings("TypeParameterUnusedInFormals")
 	public static <V> V abort(String message) {
 		throw new TestAbortedException(message);
@@ -327,8 +327,8 @@ public static <V> V abort(String message) {
 	 * @throws TestAbortedException always
 	 * @since 5.9
 	 */
-	@Contract("_ -> fail")
 	@API(status = STABLE, since = "5.9")
+	@Contract("_ -> fail")
 	@SuppressWarnings("TypeParameterUnusedInFormals")
 	public static <V> V abort(Supplier<String> messageSupplier) {
 		throw new TestAbortedException(messageSupplier.get());

junit-jupiter-api/src/main/java/org/junit/jupiter/api/AutoClose.java

@@ -75,10 +75,10 @@
  *
  * @since 5.11
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.FIELD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = MAINTAINED, since = "5.13.3")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.FIELD })
 public @interface AutoClose {
 
 	/**

junit-jupiter-api/src/main/java/org/junit/jupiter/api/BeforeAll.java

@@ -91,9 +91,9 @@
  * @see TestFactory
  * @see TestInstance
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = STABLE, since = "5.0")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
 public @interface BeforeAll {
 }

junit-jupiter-api/src/main/java/org/junit/jupiter/api/BeforeEach.java

@@ -84,9 +84,9 @@
  * @see TestFactory
  * @see TestTemplate
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = STABLE, since = "5.0")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.METHOD })
 public @interface BeforeEach {
 }

junit-jupiter-api/src/main/java/org/junit/jupiter/api/ClassTemplate.java

@@ -62,11 +62,11 @@
  * @see BeforeClassTemplateInvocationCallback
  * @see AfterClassTemplateInvocationCallback
  */
-@Target({ ElementType.ANNOTATION_TYPE, ElementType.TYPE })
-@Retention(RetentionPolicy.RUNTIME)
+@API(status = EXPERIMENTAL, since = "6.0")
 @Documented
 @Inherited
-@API(status = EXPERIMENTAL, since = "6.0")
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.ANNOTATION_TYPE, ElementType.TYPE })
 @Testable
 public @interface ClassTemplate {
 }

junit-jupiter-api/src/main/java/org/junit/jupiter/api/Disabled.java

@@ -58,10 +58,10 @@
  * @see org.junit.jupiter.api.condition.DisabledInNativeImage
  * @see org.junit.jupiter.api.extension.ExecutionCondition
  */
-@Target({ ElementType.TYPE, ElementType.METHOD })
-@Retention(RetentionPolicy.RUNTIME)
-@Documented
 @API(status = STABLE, since = "5.0")
+@Documented
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ ElementType.TYPE, ElementType.METHOD })
 public @interface Disabled {
 
 	/**