Add error-prone.picnic.tech

Author: Vincent Potucek

documentation/src/main/java/example/domain/Person.java

@@ -55,8 +55,8 @@ public int hashCode() {
 		final int prime = 31;
 		int result = 1;
 		result = prime * result + ((firstName == null) ? 0 : firstName.hashCode());
-		result = prime * result + ((lastName == null) ? 0 : lastName.hashCode());
-		return result;
+		return prime * result + ((lastName == null) ? 0 : lastName.hashCode());
+		
 	}
 
 	@Override

gradle/libs.versions.toml

@@ -31,7 +31,9 @@ bndlib = { module = "biz.aQute.bnd:biz.aQute.bndlib", version.ref = "bnd" }
 checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checkstyle" }
 classgraph = { module = "io.github.classgraph:classgraph", version = "4.8.181" }
 commons-io = { module = "commons-io:commons-io", version = "2.20.0" }
-errorProne-core = { module = "com.google.errorprone:error_prone_core", version = "2.42.0" }
+error-prone-core = { module = "com.google.errorprone:error_prone_core", version = "2.42.0" }
+error-prone-contrib = { module = "tech.picnic.error-prone-support:error-prone-contrib", version = "0.25.0" }
+refaster-runner = { module = "tech.picnic.error-prone-support:refaster-runner", version = "0.25.0" }
 fastcsv = { module = "de.siegmar:fastcsv", version = "4.0.0" }
 groovy = { module = "org.apache.groovy:groovy", version = "5.0.1" }
 groovy2-bom = { module = "org.codehaus.groovy:groovy-bom", version = "2.5.23" }

gradle/plugins/common/src/main/kotlin/junitbuild.java-nullability-conventions.gradle.kts

@@ -9,8 +9,10 @@ plugins {
 }
 
 dependencies {
-	errorprone(dependencyFromLibs("errorProne-core"))
+	errorprone(dependencyFromLibs("error-prone-contrib"))
+	errorprone(dependencyFromLibs("error-prone-core"))
 	errorprone(dependencyFromLibs("nullaway"))
+	errorprone(dependencyFromLibs("refaster-runner"))
 	constraints {
 		errorprone("com.google.guava:guava") {
 			version {
@@ -27,6 +29,65 @@ nullaway {
 
 tasks.withType<JavaCompile>().configureEach {
 	options.errorprone {
+		disableWarningsInGeneratedCode = true
+		allErrorsAsWarnings = true
+		errorproneArgs.add("-XepOpt:Refaster:NamePattern=^(?!.*Rules\\\$).*") // not complain; reduce after merge.
+	 	if (System.getenv("IN_PLACE")?.toBooleanStrictOrNull() ?: false) {
+			errorproneArgs.addAll(
+				"-XepPatchLocation:IN_PLACE", // somehow only picnic works
+				"-XepPatchChecks:" +
+					"AddNullMarkedToPackageInfo," +
+					"AmbiguousJsonCreator," +
+					"AssertJNullnessAssertion," +
+					"AutowiredConstructor," +
+					"CanonicalAnnotationSyntax," +
+					"CanonicalClassNameUsage," +
+					"ClassCastLambdaUsage," +
+					"CollectorMutability," +
+					"ConstantNaming," +
+					"DeadException," +
+					"DefaultCharset," +
+					"DirectReturn," + // why only this working?
+					"EagerStringFormatting," +
+					"EmptyMethod," +
+					"EmptyMonoZip," +
+					"ExplicitArgumentEnumeration," +
+					"ExplicitEnumOrdering," +
+					"FluxFlatMapUsage," +
+					"FluxImplicitBlock," +
+					"FormatStringConcatenation," +
+					"IdentityConversion," +
+					"ImmutablesSortedSetComparator," +
+					"IsInstanceLambdaUsage," +
+					"JUnitClassModifiers," +
+					"JUnitMethodDeclaration," +
+					"JUnitNullaryParameterizedTestDeclaration," +
+					"JUnitValueSource," +
+					"LexicographicalAnnotationAttributeListing," +
+					"LexicographicalAnnotationListing," +
+					"MissingOverride," +
+					"MockitoMockClassReference," +
+					"MockitoStubbing," +
+					"MongoDBTextFilterUsage," +
+					"NestedOptionals," +
+					"NestedPublishers," +
+					"NonEmptyMono," +
+					"NonStaticImport," +
+					"OptionalOrElseGet," +
+					"PrimitiveComparison," +
+					"RedundantStringConversion," +
+					"RedundantStringEscape," +
+					"RefasterAnyOfUsage," +
+					"RequestMappingAnnotation," +
+					"RequestParamType," +
+					"Slf4jLogStatement," +
+					"Slf4jLoggerDeclaration," +
+					"SpringMvcAnnotation," +
+					"StaticImport," +
+					"StringJoin," + // why only this working?
+					"TimeZoneUsage"
+			);
+		}
 		val shouldDisableErrorProne = java.toolchain.implementation.orNull == JvmImplementation.J9
 		if (name == "compileJava" && !shouldDisableErrorProne) {
 			disable(
@@ -50,6 +111,58 @@ tasks.withType<JavaCompile>().configureEach {
 				// Produces a lot of findings that we consider to be false positives, for example for package-private
 				// classes and methods
 				"MissingSummary",
+
+				// picnic (TBD) https://error-prone.picnic.tech
+				"AddNullMarkedToPackageInfo",
+				"AmbiguousJsonCreator",
+				"AssertJNullnessAssertion",
+				"AutowiredConstructor",
+				"CanonicalAnnotationSyntax",
+				"CanonicalClassNameUsage",
+				"ClassCastLambdaUsage",
+				"CollectorMutability",
+				"ConstantNaming",
+				"DeadException",
+				"DefaultCharset",
+				"EagerStringFormatting",
+				"EmptyMethod",
+				"EmptyMonoZip",
+				"ExplicitArgumentEnumeration",
+				"ExplicitEnumOrdering",
+				"FluxFlatMapUsage",
+				"FluxImplicitBlock",
+				"FormatStringConcatenation",
+				"IdentityConversion",
+				"ImmutablesSortedSetComparator",
+				"IsInstanceLambdaUsage",
+				"JUnitClassModifiers",
+				"JUnitMethodDeclaration",
+				"JUnitNullaryParameterizedTestDeclaration",
+				"JUnitValueSource",
+				"LexicographicalAnnotationAttributeListing",
+				"LexicographicalAnnotationListing",
+				"LexicographicalAnnotationListing",
+				"MissingOverride",
+				"MockitoMockClassReference",
+				"MockitoStubbing",
+				"MongoDBTextFilterUsage",
+				"NestedOptionals",
+				"NestedPublishers",
+				"NonEmptyMono",
+				"NonStaticImport",
+				"OptionalOrElseGet",
+				"PrimitiveComparison",
+				"RedundantStringConversion",
+				"RedundantStringEscape",
+				"RequestMappingAnnotation",
+				"RequestParamType",
+				"Slf4jLogStatement",
+				"Slf4jLoggerDeclaration",
+				"SpringMvcAnnotation",
+				"StaticImport",
+				"TimeZoneUsage",
+				// "DirectReturn", fixed
+				// "StringJoin", fixed
 			)
 			error("PackageLocation")
 		} else {

junit-platform-commons/src/main/java/org/junit/platform/commons/util/ModuleUtils.java

@@ -231,8 +231,8 @@ List<Class<?>> scan(ModuleReference reference) {
 		 */
 		private String className(String resourceName) {
 			resourceName = resourceName.substring(0, resourceName.length() - 6); // 6 = ".class".length()
-			resourceName = resourceName.replace('/', '.');
-			return resourceName;
+			return resourceName.replace('/', '.');
+			
 		}
 
 		/**