-
Notifications
You must be signed in to change notification settings - Fork 36
Fix document outline overflowing off the screen #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8e1576d The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for myst-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Marked this as ready for review despite the fact that I did not properly test it, because the change is very simple and provides significant value to many users, including readers of the MyST documentation (I encountered this bug when reading the development docs) and participants in the JupyterCon workshop I'm helping to organize next week. I hope that's not out of line or burdensome! |
|
Thanks for this PR. How did you settle on the particular length value? |
|
Trial-and-error in the browser dev tools :) I think there's likely a better solution which doesn't require magic numbers, but I don't know what it is and felt it was more important to replace the current magic number with a better magic number to fix the bug in the short-term ;) |
choldgraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We took a look at this in the colab cafe, here's where we landed:
- We'll merge this!
- It is an improvement over what's there, because currently you cannot access the bottom of a long TOC.
- It exposed a bug where the TOC overlaps with the footer, but this is still an improvement
Resolves #337
I've tested this change in my browser dev tools, and attempted to translate the change which worked there into the myst-theme code. I think I've done it in the right place, but I've been unable to follow the development instructions to test this so far. Opened #666 ( 😆 ) for that.