Skip to content

Conversation

@mfisher87
Copy link
Contributor

@mfisher87 mfisher87 commented Oct 26, 2025

Resolves #337

I've tested this change in my browser dev tools, and attempted to translate the change which worked there into the myst-theme code. I think I've done it in the right place, but I've been unable to follow the development instructions to test this so far. Opened #666 ( 😆 ) for that.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2025

🦋 Changeset detected

Latest commit: 8e1576d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@myst-theme/site Patch
@myst-theme/providers Patch
@myst-theme/frontmatter Patch
@myst-theme/diagrams Patch
@myst-theme/jupyter Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch
@myst-theme/landing-pages Patch
@myst-theme/book Patch
@myst-theme/article Patch
myst-to-react Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 26, 2025

Deploy Preview for myst-theme ready!

Name Link
🔨 Latest commit 8e1576d
🔍 Latest deploy log https://app.netlify.com/projects/myst-theme/deploys/691cccef1cc72300084f037e
😎 Deploy Preview https://deploy-preview-665--myst-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mfisher87 mfisher87 marked this pull request as ready for review October 26, 2025 19:37
@mfisher87
Copy link
Contributor Author

mfisher87 commented Oct 26, 2025

Marked this as ready for review despite the fact that I did not properly test it, because the change is very simple and provides significant value to many users, including readers of the MyST documentation (I encountered this bug when reading the development docs) and participants in the JupyterCon workshop I'm helping to organize next week. I hope that's not out of line or burdensome!

@agoose77
Copy link
Collaborator

agoose77 commented Nov 9, 2025

Thanks for this PR. How did you settle on the particular length value?

@mfisher87
Copy link
Contributor Author

Trial-and-error in the browser dev tools :) I think there's likely a better solution which doesn't require magic numbers, but I don't know what it is and felt it was more important to replace the current magic number with a better magic number to fix the bug in the short-term ;)

Copy link
Contributor

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We took a look at this in the colab cafe, here's where we landed:

  • We'll merge this!
  • It is an improvement over what's there, because currently you cannot access the bottom of a long TOC.
  • It exposed a bug where the TOC overlaps with the footer, but this is still an improvement

@choldgraf choldgraf merged commit 3a334e5 into jupyter-book:main Nov 18, 2025
3 checks passed
@mfisher87 mfisher87 deleted the fix-outline-overflow branch November 18, 2025 19:59
@choldgraf choldgraf added the bug Something isn't working label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right-hand navigation runs over page

3 participants