More CI Cleanup (#742)

Author: blink1073

.github/workflows/python-linux.yml

@@ -54,7 +54,7 @@ jobs:
       - name: Run the tests
         if: ${{ matrix.python-version != 'pypy-3.7' }}
         run: |
-          pytest -vv --cov jupyter_server --cov-branch --cov-report term-missing:skip-covered || pytest -vv --cov jupyter_server --cov-branch --cov-report term-missing:skip-covered --lf
+          pytest -vv --cov jupyter_server --cov-branch --cov-report term-missing:skip-covered  --cov-fail-under 70 || pytest -vv --cov jupyter_server --cov-branch --cov-report term-missing:skip-covered --cov-fail-under 70 --lf
       - name: Run the tests on pypy
         if: ${{ matrix.python-version == 'pypy-3.7' }}
         run: |

.mailmap

@@ -26,7 +26,7 @@ David Hirschfeld <[email protected]> dhirschfeld <david.hirschfeld
 David P. Sanders <[email protected]> David P. Sanders <[email protected]>
 David Warde-Farley <[email protected]> David Warde-Farley <>
 Doug Blank <[email protected]> Doug Blank <[email protected]>
-Eugene Van den Bulke <[email protected]> Eugene Van den Bulke <[email protected]> 
+Eugene Van den Bulke <[email protected]> Eugene Van den Bulke <[email protected]>
 Evan Patterson <[email protected]> <[email protected]>
 Evan Patterson <[email protected]> <[email protected]>
 Evan Patterson <[email protected]> <[email protected]>

.pre-commit-config.yaml

@@ -15,10 +15,16 @@ repos:
     hooks:
       - id: prettier
 
-  - repo: https://gitlab.com/pycqa/flake8
+  - repo: https://github.com/pycqa/flake8
     rev: 4.0.1
     hooks:
       - id: flake8
+        additional_dependencies:
+          [
+            "flake8-bugbear==20.1.4",
+            "flake8-logging-format==0.6.0",
+            "flake8-implicit-str-concat==0.2.0",
+          ]
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.1.0
@@ -33,6 +39,8 @@ repos:
       - id: check-yaml
       - id: debug-statements
       - id: forbid-new-submodules
+      - id: check-builtin-literals
+      - id: trailing-whitespace
 
   - repo: https://github.com/pre-commit/mirrors-eslint
     rev: v8.8.0

docs/Makefile

@@ -176,7 +176,7 @@ linkcheck:
 	@echo
 	@echo "Link check complete; look for any errors in the above output " \
 	      "or in $(BUILDDIR)/linkcheck/output.txt."
-		  
+
 spelling:
 	$(SPHINXBUILD) -b spelling $(ALLSPHINXOPTS) $(BUILDDIR)/spelling
 	@echo "Spell check complete; look for any errors in the above output " \

docs/autogen_config.py

@@ -37,7 +37,7 @@
 """
 try:
     destination = os.path.join(os.path.dirname(__file__), "source/other/full-config.rst")
-except:
+except BaseException:
     destination = os.path.join(os.getcwd(), "full-config.rst")
 
 with open(destination, "w") as f:

docs/source/conf.py

@@ -279,17 +279,6 @@
 
 # -- Options for LaTeX output ---------------------------------------------
 
-latex_elements = {
-    # The paper size ('letterpaper' or 'a4paper').
-    #'papersize': 'letterpaper',
-    # The font size ('10pt', '11pt' or '12pt').
-    #'pointsize': '10pt',
-    # Additional stuff for the LaTeX preamble.
-    #'preamble': '',
-    # Latex figure (float) alignment
-    #'figure_align': 'htbp',
-}
-
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title,
 #  author, documentclass [howto, manual, or own class]).

examples/simple/jupyter_server_config.py

@@ -2,5 +2,5 @@
 # ------------------------------------------------------------------------------
 # Application(SingletonConfigurable) configuration
 # ------------------------------------------------------------------------------
-## The date format used by logging formatters for %(asctime)s
+# The date format used by logging formatters for %(asctime)s
 c.Application.log_datefmt = "%Y-%m-%d %H:%M:%S Simple_Extensions_Example"

examples/simple/pytest.ini

@@ -1,3 +1,3 @@
 [pytest]
 # Disable any upper exclusion.
-norecursedirs = 
+norecursedirs =

examples/simple/simple_ext11/application.py

@@ -57,7 +57,7 @@ def simple11_dir_formatted(self):
 
     def initialize_settings(self):
         self.log.info("hello: {}".format(self.hello))
-        if self.hello == True:
+        if self.hello is True:
             self.log.info(
                 "Hello Simple11: You have launched with --hello flag or defined 'c.SimpleApp1.hello == True' in your config file"
             )

jupyter_server/auth/login.py

@@ -229,10 +229,10 @@ def validate_security(cls, app, ssl_options=None):
         if not app.ip:
             warning = "WARNING: The Jupyter server is listening on all IP addresses"
             if ssl_options is None:
-                app.log.warning(warning + " and not using encryption. This " "is not recommended.")
+                app.log.warning(f"{warning} and not using encryption. This is not recommended.")
             if not app.password and not app.token:
                 app.log.warning(
-                    warning + " and not using authentication. "
+                    f"{warning} and not using authentication. "
                     "This is highly insecure and not recommended."
                 )
         else: