Apply more fixes/add noqa based on judgment

Author: krassowski

examples/authorization/jupyter_nbclassic_readonly_config.py

@@ -8,9 +8,7 @@ class ReadOnly(Authorizer):
 
     def is_authorized(self, handler, user, action, resource):
         """Only allows `read` operations."""
-        if action != "read":
-            return False
-        return True
+        return action == "read"
 
 
 c.ServerApp.authorizer_class = ReadOnly  # type:ignore[name-defined]

examples/authorization/jupyter_nbclassic_rw_config.py

@@ -8,9 +8,7 @@ class ReadWriteOnly(Authorizer):
 
     def is_authorized(self, handler, user, action, resource):
         """Only allows `read` and `write` operations."""
-        if action not in {"read", "write"}:
-            return False
-        return True
+        return action in {"read", "write"}
 
 
 c.ServerApp.authorizer_class = ReadWriteOnly  # type:ignore[name-defined]

examples/authorization/jupyter_temporary_config.py

@@ -8,9 +8,7 @@ class TemporaryServerPersonality(Authorizer):
 
     def is_authorized(self, handler, user, action, resource):
         """Allow everything but write on contents"""
-        if action == "write" and resource == "contents":
-            return False
-        return True
+        return not (action == "write" and resource == "contents")
 
 
 c.ServerApp.authorizer_class = TemporaryServerPersonality  # type:ignore[name-defined]

jupyter_server/base/handlers.py

@@ -15,7 +15,6 @@
 import warnings
 from collections.abc import Awaitable, Coroutine, Sequence
 from http.client import responses
-from logging import Logger
 from typing import TYPE_CHECKING, Any, cast
 from urllib.parse import urlparse
 
@@ -44,6 +43,8 @@
 )
 
 if TYPE_CHECKING:
+    from logging import Logger
+
     from jupyter_client.kernelspec import KernelSpecManager
     from jupyter_events import EventLogger
     from jupyter_server_terminals.terminalmanager import TerminalManager
@@ -774,7 +775,7 @@ def write_error(self, status_code: int, **kwargs: Any) -> None:
                 # backward-compatibility: traceback field is present,
                 # but always empty
                 reply["traceback"] = ""
-        self.log.warning("wrote error: %r", reply["message"], exc_info=True)
+        self.log.warning("wrote error: %r", reply["message"])
         self.finish(json.dumps(reply))
 
     def get_login_url(self) -> str:
@@ -1055,7 +1056,7 @@ def get_absolute_path(cls, roots: Sequence[str], path: str) -> str:
             log().debug(f"Path {path} served from {abspath}")
             return abspath
 
-    def validate_absolute_path(self, root: str, absolute_path: str) -> str | None:
+    def validate_absolute_path(self, _root: str, absolute_path: str) -> str | None:
         """check if the file should be served (raises 404, 403, etc.)"""
         if not absolute_path:
             raise web.HTTPError(404)
@@ -1115,7 +1116,7 @@ class FilesRedirectHandler(JupyterHandler):
     """Handler for redirecting relative URLs to the /files/ handler"""
 
     @staticmethod
-    async def redirect_to_files(self: Any, path: str) -> None:
+    async def redirect_to_files(self: Any, path: str) -> None:  # noqa: PLW0211
         """make redirect logic a reusable static method
 
         so it can be called from other handlers.

jupyter_server/extension/handler.py

@@ -2,15 +2,16 @@
 
 from __future__ import annotations
 
-from logging import Logger
 from typing import TYPE_CHECKING, Any, cast
 
-from jinja2 import Template
 from jinja2.exceptions import TemplateNotFound
 
 from jupyter_server.base.handlers import FileFindHandler
 
 if TYPE_CHECKING:
+    from logging import Logger
+
+    from jinja2 import Template
     from traitlets.config import Config
 
     from jupyter_server.extension.application import ExtensionApp

jupyter_server/gateway/gateway_client.py

@@ -534,7 +534,7 @@ def gateway_enabled(self):
         return bool(self.url is not None and len(self.url) > 0)
 
     # Ensure KERNEL_LAUNCH_TIMEOUT has a default value.
-    KERNEL_LAUNCH_TIMEOUT = int(os.environ.get("KERNEL_LAUNCH_TIMEOUT", 40))
+    KERNEL_LAUNCH_TIMEOUT = int(os.environ.get("KERNEL_LAUNCH_TIMEOUT", "40"))
 
     _connection_args: dict[str, ty.Any]  # initialized on first use
 

jupyter_server/kernelspecs/handlers.py

@@ -29,7 +29,7 @@ async def get(self, kernel_name, path, include_body=True):
         """Get a kernelspec resource."""
         ksm = self.kernel_spec_manager
         if path.lower().endswith(".png"):
-            self.set_header("Cache-Control", f"max-age={60*60*24*30}")
+            self.set_header("Cache-Control", f"max-age={60 * 60 * 24 * 30}")
         ksm = self.kernel_spec_manager
         if hasattr(ksm, "get_kernel_spec_resource"):
             # If the kernel spec manager defines a method to get kernelspec resources,

jupyter_server/log.py

@@ -33,7 +33,7 @@ def _scrub_uri(uri: str, extra_param_keys=None) -> str:
         parts = parsed.query.split("&")
         changed = False
         for i, s in enumerate(parts):
-            key, sep, value = s.partition("=")
+            key, sep, _value = s.partition("=")
             for substring in scrub_param_keys:
                 if substring in key:
                     parts[i] = f"{key}{sep}[secret]"

jupyter_server/nbconvert/handlers.py

@@ -104,7 +104,7 @@ async def get(self, format, path):
         # give its path to nbconvert.
         if hasattr(self.contents_manager, "_get_os_path"):
             os_path = self.contents_manager._get_os_path(path)
-            ext_resources_dir, basename = os.path.split(os_path)
+            ext_resources_dir, _basename = os.path.split(os_path)
         else:
             ext_resources_dir = None
 

jupyter_server/serverapp.py

@@ -2472,7 +2472,7 @@ def _confirm_exit(self) -> None:
         no = _i18n("n")
         sys.stdout.write(_i18n("Shut down this Jupyter server (%s/[%s])? ") % (yes, no))
         sys.stdout.flush()
-        r, w, x = select.select([sys.stdin], [], [], 5)
+        r, _w, _x = select.select([sys.stdin], [], [], 5)
         if r:
             line = sys.stdin.readline()
             if line.lower().startswith(yes) and no not in line.lower():