Skip to content

Commit ca59aeb

Browse files
authored
Merge pull request #169 from consideRatio/pr/groups-multi-followup
groups dashboard: filter out the pseudo group 'multiple'
2 parents 2647b53 + d9217a5 commit ca59aeb

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

dashboards/common.libsonnet

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,13 @@ local _getDashedLineOverride(pattern, color) = {
185185
+ var.query.withDatasourceFromVariable(self.prometheus)
186186
+ var.query.selectionOptions.withMulti()
187187
+ var.query.selectionOptions.withIncludeAll(value=true, customAllValue='.*')
188+
// If jupyterhub-groups-exporter is configured with `double_count=True` as
189+
// it is by default, a pseudo group named `multiple` will also be reported
190+
// by jupyterhub-groups-exporter next to real groups and the `none` group.
191+
// A user part of multiple real groups, will also be part of the `multiple`
192+
// pseudo-group. Presenting this groups is assumed to not improve the user
193+
// experience, so we exclude it.
194+
+ var.query.withRegex('^(?!multiple$).+')
188195
+ var.query.queryTypes.withLabelValues('usergroup', 'jupyterhub_user_group_info')
189196
,
190197
user_name:

dashboards/group.jsonnet

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ local memoryUsage =
4242
group(
4343
# duplicate jupyterhub_user_group_info's username label as annotation_hub_jupyter_org_username
4444
label_replace(
45-
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group"},
45+
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group", usergroup!="multiple"},
4646
"annotation_hub_jupyter_org_username", "$1", "username", "(.+)"
4747
)
4848
) by (namespace, annotation_hub_jupyter_org_username, usergroup)
@@ -92,7 +92,7 @@ local cpuUsage =
9292
group(
9393
# duplicate jupyterhub_user_group_info's username label as annotation_hub_jupyter_org_username
9494
label_replace(
95-
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group"},
95+
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group", usergroup!="multiple"},
9696
"annotation_hub_jupyter_org_username", "$1", "username", "(.+)"
9797
)
9898
) by (namespace, annotation_hub_jupyter_org_username, usergroup)
@@ -134,14 +134,14 @@ local homedirSharedUsage =
134134
# match using username_safe (kubespawner's modern "safe" scheme)
135135
# duplicate jupyterhub_user_group_info's username_safe label as directory
136136
label_replace(
137-
jupyterhub_user_group_info{namespace=~"$hub_name", username_safe=~".*", usergroup=~"$user_group"},
137+
jupyterhub_user_group_info{namespace=~"$hub_name", username_safe=~".*", usergroup=~"$user_group", usergroup!="multiple"},
138138
"directory", "$1", "username_safe", "(.+)"
139139
)
140140
or
141141
# match using username_escaped (kubespawner's legacy "escape" scheme)
142142
# duplicate jupyterhub_user_group_info's username_escaped label as directory
143143
label_replace(
144-
jupyterhub_user_group_info{namespace=~"$hub_name", username_escaped=~".*", usergroup=~"$user_group"},
144+
jupyterhub_user_group_info{namespace=~"$hub_name", username_escaped=~".*", usergroup=~"$user_group", usergroup!="multiple"},
145145
"directory", "$1", "username_escaped", "(.+)"
146146
)
147147
) by (namespace, directory, usergroup)
@@ -188,7 +188,7 @@ local memoryRequests =
188188
group(
189189
# duplicate jupyterhub_user_group_info's username label as annotation_hub_jupyter_org_username
190190
label_replace(
191-
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group"},
191+
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group", usergroup!="multiple"},
192192
"annotation_hub_jupyter_org_username", "$1", "username", "(.+)"
193193
)
194194
) by (namespace, annotation_hub_jupyter_org_username, usergroup)
@@ -237,7 +237,7 @@ local cpuRequests =
237237
group(
238238
# duplicate jupyterhub_user_group_info's username label as annotation_hub_jupyter_org_username
239239
label_replace(
240-
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group"},
240+
jupyterhub_user_group_info{namespace=~"$hub_name", username=~".*", usergroup=~"$user_group", usergroup!="multiple"},
241241
"annotation_hub_jupyter_org_username", "$1", "username", "(.+)"
242242
)
243243
) by (namespace, annotation_hub_jupyter_org_username, usergroup)

0 commit comments

Comments
 (0)