Skip to content

Commit 9da9611

Browse files
authored
Merge pull request #3534 from colinlodter/main
add appProtocol to hub service definition
2 parents e93df36 + 82a7dda commit 9da9611

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

jupyterhub/templates/hub/service.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ spec:
3131
{{- with .Values.hub.service.ports.nodePort }}
3232
nodePort: {{ . }}
3333
{{- end }}
34+
{{- with .Values.hub.service.ports.appProtocol }}
35+
appProtocol: {{ . }}
36+
{{- end }}
3437

3538
{{- with .Values.hub.service.extraPorts }}
3639
{{- . | toYaml | nindent 4 }}

jupyterhub/values.schema.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1104,6 +1104,10 @@ properties:
11041104
description: |
11051105
Object to configure the ports the hub service will be deployed on.
11061106
properties:
1107+
appProtocol:
1108+
type: [string, "null"]
1109+
description: |
1110+
The application protocol to utilize with the Service port. This may be required when an external application attempts to make calls to the hub service with a protocol the hub does not support.
11071111
nodePort:
11081112
type: [integer, "null"]
11091113
minimum: 0
@@ -2760,7 +2764,7 @@ properties:
27602764
extraPaths:
27612765
type: array
27622766
description: |
2763-
A list of custom paths to be added to the ingress configuration.
2767+
A list of custom paths to be added to the ingress configuration.
27642768
27652769
See [the Kubernetes documentation](https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types)
27662770
for more details about paths.

jupyterhub/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ hub:
4141
annotations: {}
4242
ports:
4343
nodePort:
44+
appProtocol:
4445
extraPorts: []
4546
loadBalancerIP:
4647
baseUrl: /

0 commit comments

Comments
 (0)