Remove deprecated SpotifyWebAPI::addMyTracks() option

Author: jwilsson

src/SpotifyWebAPI.php

@@ -266,16 +266,16 @@ public function addMyShows(string|array $shows): bool
      *
      * @return bool Whether the tracks was successfully added.
      */
-    public function addMyTracks(string|array|object $tracks): bool
+    public function addMyTracks(array|object $tracks): bool
     {
-        $tracks = is_object($tracks) ? (array) $tracks : $tracks;
+        $tracks = (array) $tracks;
 
-        if (is_array($tracks) && isset($tracks['ids'])) {
+        if (isset($tracks['ids'])) {
             $tracks = (array) $this->uriToId($tracks['ids'], 'track');
             $options = json_encode([
                 'ids' => $tracks,
             ]);
-        } elseif (is_array($tracks) && isset($tracks['timestamped_ids'])) {
+        } elseif (isset($tracks['timestamped_ids'])) {
             $tracks = array_map(function ($item) {
                 $item['id'] = $this->uriToId($item['id'], 'track');
 
@@ -285,17 +285,6 @@ public function addMyTracks(string|array|object $tracks): bool
             $options = json_encode([
                 'timestamped_ids' => $tracks,
             ]);
-        } else {
-            trigger_error(
-                // phpcs:ignore
-                'Passing string or array without "ids" or "timestamped_ids" key to SpotifyWebAPI::addMyTracks() is deprecated',
-                E_USER_DEPRECATED
-            );
-
-            $tracks = (array) $this->uriToId($tracks, 'track');
-            $options = json_encode([
-                'ids' => $tracks,
-            ]);
         }
 
         $headers = [

tests/SpotifyWebAPITest.php

@@ -280,37 +280,6 @@ public function testAddMyTracksTimestampedIds()
         );
     }
 
-    public function testAddMyTracksDeprecated()
-    {
-        $tracks = [
-            '1id6H6vcwSB9GGv9NXh5cl',
-            '3mqRLlD9j92BBv1ueFhJ1l',
-            'spotify:track:1id6H6vcwSB9GGv9NXh5cl',
-        ];
-
-        $expected = json_encode([
-            'ids' => [
-                '1id6H6vcwSB9GGv9NXh5cl',
-                '3mqRLlD9j92BBv1ueFhJ1l',
-                '1id6H6vcwSB9GGv9NXh5cl',
-            ],
-        ]);
-
-        $headers = ['Content-Type' => 'application/json'];
-        $return = ['status' => 200];
-        $api = $this->setupApi(
-            'PUT',
-            '/v1/me/tracks',
-            $expected,
-            $headers,
-            $return
-        );
-
-        $this->assertTrue(
-            $api->addMyTracks($tracks)
-        );
-    }
-
     public function testAddPlaylistTracks()
     {
         $tracks = [