feat: Refactored the async API.

- Restarting the I/O loop uses an API that no
longer relies on operator overloads, and uses a more
sensible naming scheme for submitting i/O operations.

Author: kcexn

include/net/service/async_tcp_service.hpp

@@ -115,13 +115,13 @@ class async_tcp_service {
    */
   auto start(async_context &ctx) noexcept -> void;
   /**
-   * @brief Read data from a connected socket.
+   * @brief Submits an asynchronous socket recv.
    * @param ctx The async context to start the reader on.
    * @param socket the socket to read data from.
    * @param rctx A shared pointer to a mutable read buffer.
    */
-  auto reader(async_context &ctx, const socket_dialog &socket,
-              std::shared_ptr<read_context> rctx) -> void;
+  auto submit_recv(async_context &ctx, const socket_dialog &socket,
+                   std::shared_ptr<read_context> rctx) -> void;
 
 protected:
   /** @brief Default constructor. */

include/net/service/async_udp_service.hpp

@@ -118,13 +118,13 @@ class async_udp_service {
    */
   auto start(async_context &ctx) noexcept -> void;
   /**
-   * @brief Read data from a connected socket.
+   * @brief Submits an asynchronous socket recv.
    * @param ctx The async context to start the reader on.
    * @param socket the socket to read data from.
    * @param rctx A shared pointer to a mutable read buffer.
    */
-  auto reader(async_context &ctx, const socket_dialog &socket,
-              std::shared_ptr<read_context> rctx) -> void;
+  auto submit_recv(async_context &ctx, const socket_dialog &socket,
+                   std::shared_ptr<read_context> rctx) -> void;
 
 protected:
   /** @brief Default constructor. */

include/net/service/impl/async_tcp_service_impl.hpp

@@ -84,7 +84,7 @@ auto async_tcp_service<TCPStreamHandler, Size>::acceptor(
 }
 
 template <typename TCPStreamHandler, std::size_t Size>
-auto async_tcp_service<TCPStreamHandler, Size>::reader(
+auto async_tcp_service<TCPStreamHandler, Size>::submit_recv(
     async_context &ctx, const socket_dialog &socket,
     std::shared_ptr<read_context> rctx) -> void
 {
@@ -113,8 +113,8 @@ auto async_tcp_service<TCPStreamHandler, Size>::emit(
     async_context &ctx, const socket_dialog &socket,
     std::shared_ptr<read_context> rctx, std::span<const std::byte> buf) -> void
 {
-  auto &handle = static_cast<TCPStreamHandler &>(*this);
-  handle(ctx, socket, std::move(rctx), buf);
+  static_cast<TCPStreamHandler *>(this)->service(ctx, socket, std::move(rctx),
+                                                 buf);
 }
 
 template <typename TCPStreamHandler, std::size_t Size>

include/net/service/impl/async_udp_service_impl.hpp

@@ -54,12 +54,12 @@ auto async_udp_service<UDPStreamHandler, Size>::start(
 
   server_sockfd_ = static_cast<socket_type>(sock);
 
-  reader(ctx, ctx.poller.emplace(std::move(sock)),
-         std::make_shared<read_context>());
+  submit_recv(ctx, ctx.poller.emplace(std::move(sock)),
+              std::make_shared<read_context>());
 }
 
 template <typename UDPStreamHandler, std::size_t Size>
-auto async_udp_service<UDPStreamHandler, Size>::reader(
+auto async_udp_service<UDPStreamHandler, Size>::submit_recv(
     async_context &ctx, const socket_dialog &socket,
     std::shared_ptr<read_context> rctx) -> void
 {
@@ -84,8 +84,8 @@ auto async_udp_service<UDPStreamHandler, Size>::emit(
     async_context &ctx, const socket_dialog &socket,
     std::shared_ptr<read_context> rctx, std::span<const std::byte> buf) -> void
 {
-  auto &handle = static_cast<UDPStreamHandler &>(*this);
-  handle(ctx, socket, std::move(rctx), buf);
+  static_cast<UDPStreamHandler *>(this)->service(ctx, socket, std::move(rctx),
+                                                 buf);
 }
 
 template <typename UDPStreamHandler, std::size_t Size>

tests/test_tcp_fixture.hpp

@@ -53,17 +53,18 @@ struct tcp_echo_service : public async_tcp_service<tcp_echo_service> {
     using namespace io::socket;
     using namespace stdexec;
 
-    sender auto sendmsg =
-        io::sendmsg(socket, msg, 0) |
-        then([&, socket, rctx](auto &&len) { reader(ctx, socket, rctx); }) |
-        upon_error([](auto &&error) {});
+    sender auto sendmsg = io::sendmsg(socket, msg, 0) |
+                          then([&, socket, rctx](auto &&len) {
+                            submit_recv(ctx, socket, rctx);
+                          }) |
+                          upon_error([](auto &&error) {});
 
     ctx.scope.spawn(std::move(sendmsg));
   }
 
-  auto operator()(async_context &ctx, const socket_dialog &socket,
-                  std::shared_ptr<read_context> rctx,
-                  std::span<const std::byte> buf) -> void
+  auto service(async_context &ctx, const socket_dialog &socket,
+               std::shared_ptr<read_context> rctx,
+               std::span<const std::byte> buf) -> void
   {
     echo(ctx, socket, rctx, {.buffers = buf});
   }

tests/test_udp_fixture.hpp

@@ -52,16 +52,16 @@ struct udp_echo_service : public async_udp_service<udp_echo_service> {
 
     sender auto sendmsg = io::sendmsg(socket, msg, 0) |
                           then([&, socket, rctx, msg](auto &&len) mutable {
-                            reader(ctx, socket, std::move(rctx));
+                            submit_recv(ctx, socket, std::move(rctx));
                           }) |
                           upon_error([](auto &&error) {});
 
     ctx.scope.spawn(std::move(sendmsg));
   }
 
-  auto operator()(async_context &ctx, const socket_dialog &socket,
-                  std::shared_ptr<read_context> rctx,
-                  std::span<const std::byte> buf) -> void
+  auto service(async_context &ctx, const socket_dialog &socket,
+               std::shared_ptr<read_context> rctx,
+               std::span<const std::byte> buf) -> void
   {
     using namespace io::socket;
     if (!rctx)