proxy/authentication: set proper 10h resync period

sttts · sttts · commit 5ce1a433f4d3 · 2024-09-19T11:44:14.000+02:00
Signed-off-by: Dr. Stefan Schimanski &lt;stefan.schimanski@gmail.com&gt;
diff --git a/pkg/proxy/options/authentication.go b/pkg/proxy/options/authentication.go
@@ -38,6 +38,8 @@ import (
 	kcpauthentication "github.com/kcp-dev/kcp/pkg/proxy/authentication"
 )
 
+const resyncPeriod = 10 * time.Hour
+
 // Authentication wraps BuiltInAuthenticationOptions so we can minimize the
 // dependencies on apiserver auth machinery, specifically by overriding the
 // ApplyTo so we can remove those config dependencies not relevant to the
@@ -111,7 +113,7 @@ func (c *Authentication) ApplyTo(ctx context.Context, authenticationInfo *generi
 			return fmt.Errorf("failed to create client for ServiceAccountTokenGetter: %w", err)
 		}
 
-		versionedInformers := kcpkubernetesinformers.NewSharedInformerFactory(tokenGetterClient, 10*time.Minute)
+		versionedInformers := kcpkubernetesinformers.NewSharedInformerFactory(tokenGetterClient, resyncPeriod)
 
 		authenticatorConfig.ServiceAccountTokenGetter = serviceaccountcontroller.NewClusterGetterFromClient(
 			tokenGetterClient,

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,8 @@ import (`
`38`	`38`	`kcpauthentication "github.com/kcp-dev/kcp/pkg/proxy/authentication"`
`39`	`39`	`)`
`40`	`40`
	`41`	`+const resyncPeriod = 10 * time.Hour`
	`42`	`+`
`41`	`43`	`// Authentication wraps BuiltInAuthenticationOptions so we can minimize the`
`42`	`44`	`// dependencies on apiserver auth machinery, specifically by overriding the`
`43`	`45`	`// ApplyTo so we can remove those config dependencies not relevant to the`
`@@ -111,7 +113,7 @@ func (c Authentication) ApplyTo(ctx context.Context, authenticationInfo generi`
`111`	`113`	`return fmt.Errorf("failed to create client for ServiceAccountTokenGetter: %w", err)`
`112`	`114`	`}`
`113`	`115`
`114`		`- versionedInformers := kcpkubernetesinformers.NewSharedInformerFactory(tokenGetterClient, 10*time.Minute)`
	`116`	`+ versionedInformers := kcpkubernetesinformers.NewSharedInformerFactory(tokenGetterClient, resyncPeriod)`
`115`	`117`
`116`	`118`	`authenticatorConfig.ServiceAccountTokenGetter = serviceaccountcontroller.NewClusterGetterFromClient(`
`117`	`119`	`tokenGetterClient,`