-
Notifications
You must be signed in to change notification settings - Fork 423
Open
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Feature Description
ValidatingWebhookConfiguration (pkg/admission/validatingwebhook/plugin.go):
- Has getSourceClusterForGroupResource() method
- Checks APIBindings to find the source workspace
- Calls webhooks from the APIExport workspace when resources are bound
This means that any object, created in APIBinding workspace will be checked using WebhookConfiguration in Provider workspace.
And missing part:
ValidatingAdmissionPolicy (pkg/admission/validatingadmissionpolicy/validating_admission_policy.go):
- Only looks at policies in the same logical cluster (line 190-191)
- No APIBinding/cross-workspace logic
- Policies in an APIExport workspace won't apply to consuming workspaces
So ValidatingAdmissionPolicy is not implemented
Proposed Solution
Implement in the same way as ValidatingWebhookConfiguration
Add tests :)
Update docs :)
Alternative Solutions
No response
Want to contribute?
- I would like to work on this issue.
Additional Context
No response
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Type
Projects
Status
New