Merge pull request #37 from keboola/tf2-missing-manifest

No manifest behaves like empty manifest

Author: tomasfejfar

CHANGELOG.md

@@ -3,6 +3,9 @@
 
 ## master
 
+**Feature:**
+- [\#37](https://github.com/keboola/php-component/pull/37): No manifest behaves like empty manifest  
+
 ## 4.1.1
 
 **Patch:**

src/Manifest/ManifestManager.php

@@ -80,8 +80,8 @@ public function getTableManifest(string $tableName)
     private function loadManifest(string $fileName, string $baseDir): array
     {
         $isPathInDirectory = strpos($fileName, $baseDir) === 0;
+        $fs = new Filesystem();
         if (!$isPathInDirectory) {
-            $fs = new Filesystem();
             if ($fs->isAbsolutePath($fileName)) {
                 throw new InvalidArgumentException(sprintf(
                     'Manifest source "%s" must be in the data directory (%s)!',
@@ -93,8 +93,13 @@ private function loadManifest(string $fileName, string $baseDir): array
             $fileName = implode('/', [$baseDir, $fileName]);
         }
 
+        $manifestFilename = $this->getManifestFilename($fileName);
+        if (!$fs->exists($manifestFilename)) {
+            return [];
+        }
+
         $decoder = new JsonEncoder();
-        return $decoder->decode(file_get_contents($this->getManifestFilename($fileName)), JsonEncoder::FORMAT);
+        return $decoder->decode(file_get_contents($manifestFilename), JsonEncoder::FORMAT);
     }
 
     /**

tests/Manifest/ManifestManagerTest.php

@@ -97,6 +97,13 @@ public function testWillLoadTableManifest(): void
         $this->assertSame($expectedManifest, $manager->getTableManifest('people.csv'));
     }
 
+    public function testNonexistentManifestReturnsEmptyArray(): void
+    {
+        $manager = new ManifestManager(__DIR__ . '/fixtures/manifest-data-dir');
+
+        $this->assertSame([], $manager->getTableManifest('manifest-does-not-exist'));
+    }
+
     public function testWillLoadTableManifestWithoutCsv(): void
     {
         $manager = new ManifestManager(__DIR__ . '/fixtures/manifest-data-dir');